Repository navigation
Resolve ember-primitives and decorator-transforms to one version each - #2262
Merged
Merged
Conversation
The build had three versions of each package: nvp.ui asks for ember-primitives ^0.51.0, ember-container-query for ^0.57.0, and the workspace for ^0.61.1. For a 0.x version, a caret range covers one minor only, so `pnpm dedupe` cannot merge them. ember-primitives and ember-repl also pin decorator-transforms to exact versions. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
NullVoxPopuli
approved these changes
Sep 17, 2026
Contributor
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build now has one copy of
ember-primitives(0.62.0) and one ofdecorator-transforms(2.4.0). Before, it had three of each.This is for correctness, not for speed. The duplicate copies were 10 small modules, and the entry JavaScript does not change in size (892 kB to 893 kB compressed, on the
mainbuild mode).Why
pnpm dedupedoes not do itnvp.ui0.5.3ember-primitives^0.51.0ember-container-query7.0.3ember-primitives^0.57.0ember-primitives^0.61.1For a 0.x version, a caret range covers one minor only:
^0.51.0means>=0.51.0 <0.52.0. The ranges do not overlap, so this PR adds overrides inpnpm-workspace.yaml.ember-primitivesandember-replalso pindecorator-transformsto exact versions (2.3.1, 2.3.2).Risk
nvp.uiandember-container-querynow run against anember-primitivesthat is 5 to 11 minor versions newer than what they ask for.Checked:
pnpm turbo build:prod --forcepasses for all 11 tasks,lint:typespasses inapps/repl, and the Chrome suite ofapps/replpasses (67 pass, 7 skip, 0 fail). I did not run the tutorial tests or click through the UI.🤖 Generated with Claude Code