TA#83757 [14.0][IMP] delivery_custom_notification : make delivery contact selection fully dynamic#248
Merged
qtiplb merged 2 commits intoJul 16, 2026
Conversation
…ction fully dynamic Remove manual contact typing system in favor of dynamic selection. Any partner can now be selected as a delivery contact without requiring special type tagging. The 'Delivery Contacts' search filter now dynamically shows all partners currently used as delivery contacts across the system. - Remove type selection extension for 'delivery_contact' type - Add delivery_contact_for_partner_ids One2many reverse relation field - Update form view domain to allow selection of any child contact - Update search filter to use dynamic domain based on reverse relation - Update documentation to reflect new dynamic approach
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
qtiplb
changed the title
…s to super() Remove over-filtering before calling super()._send_confirmation_email(). The filtered() call that restricted to 'outgoing' pickings was preventing other picking types from being processed by parent methods, which could break compatibility with other modules or future Odoo updates. In Odoo development, recordsets should not be filtered before passing to super() unless there is a strong reason to do so.
qtiplb
deleted the
14.0-refactor-delivery_custom_notification-dynamic-contacts
branch
July 16, 2026 16:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
delivery_custom_notificationmodule to remove the manual contact typing system and make delivery contact selection fully dynamic.Key Changes:
typeselection extension for "Delivery Contact" typedelivery_contact_for_partner_idsOne2many reverse relation fieldBenefits:
Test Plan