Conversation
Plugins written for the mobile app commonly call setTimeout for fetch timeouts and retry backoff. The QuickJS runtime has no timers, so those plugins throw ReferenceError inside their own try/catch blocks and silently return zero streams on desktop (see NuvioMedia#190). - TimerBridge exposes an async __native_delay binding backed by kotlinx.coroutines.delay, capped at the plugin timeout - JsBindings gains a timer polyfill (setTimeout, clearTimeout, setInterval, clearInterval, setImmediate) built on __native_delay, with JS-side cancellation and exception containment - Desktop test covering timer firing and cancellation Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #190 (and likely most "plugin works on mobile but returns 0 streams on desktop" reports).
Problem: plugins written for the mobile app commonly call
setTimeout(fetch timeouts, retry backoff). The QuickJS runtime injectsfetch,AbortController, etc., but no timers — so those plugins throwReferenceError: setTimeout is not definedinside their own try/catch blocks and silently return zero streams on desktop.Fix:
TimerBridgehost module exposing an async__native_delaybinding backed bykotlinx.coroutines.delay(capped at the plugin timeout, cancelled with the QuickJs instance)JsBindings(setTimeout/clearTimeout/setInterval/clearInterval/setImmediate) built on__native_delay, with JS-side cancellation and exception containmentSame approach as the official quickjs-kt
setTimeoutsample.Note: the JS polyfill was validated standalone (firing, cancellation, intervals, exception containment); the Kotlin side follows the existing
HostModulepattern but was not compiled locally — please let CI run.🤖 Generated with Claude Code