Conversation
Member
|
Please do testing via https://nuvio.tv/docs Supabase credentials can be found here. Please do testing and update. |
Author
|
Thanks for the clarification and for pointing me to the contributor docs. I won’t be able to complete the runtime testing immediately because my JetBrains student license has expired, and I’m currently waiting for it to be renewed. I expect to be able to resume testing in about a week. Once I have access again, I’ll use the documented Supabase configuration, complete the visual/runtime verification, and update the PR with the results and screenshots/video. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds dominant-colour extraction for custom profile pictures added through a URL on the desktop profile-selection screen.
Custom URL avatars now use a colour derived from the loaded image for the existing animated
ProfileMeshBackground, making their hover behaviour consistent with built-in avatars.Built-in avatars retain their existing curated colours.
Fixes #217
What changed
kmpalettepainter-based dominant-colour extraction pattern.avatarColorHexas the fallback until extraction succeeds.Behaviour
For built-in avatars:
avatarColorHexcontinues to drive the animated background.For custom URL avatars:
avatarColorHexis used while the image is loading.Files changed
ProfileModels.ktresolveProfileHoverColorhelper.ProfileSelectionScreen.ktProfileHoverColorTest.ktTesting
Passed before the latest upstream
Devupdate::composeApp:compileKotlinDesktop:composeApp:testAndroidHostTest --tests "com.nuvio.app.features.profiles.ProfileHoverColorTest"git diff --checkAfter rebasing onto the latest
Dev, both desktop and Android compilation are currently blocked by unrelated upstream compilation failures, including:activeSubtitleTab/SubtitleTabreferenceshttpRequestRawactual declarationThemeSettingsStorageexpected membersTmdbSettingsStorageexpected membersThe same failures occur with this PR's changes stashed, confirming that they are unrelated to this change.
The existing
desktopTesttask is also independently blocked by the stalePluginRuntimeDesktopTest.ktsource.Manual verification status
The desktop application itself previously built and launched successfully after installing the required Windows native toolchain.
Complete visual verification is currently blocked by the contributor runtime configuration. Without:
NUVIO_SUPABASE_URLNUVIO_SUPABASE_ANON_KEYNUVIO_SUPABASE_FALLBACK_URLthe app falls back to
https://localhost, so the avatar catalogue cannot load.This PR is therefore opened as a draft pending either:
Devbuild.Scope
This PR is intentionally limited to issue #217.
It does not change: