feat(player): Windows HDMI audio bitstream passthrough - #435
Open
umarjamilpc wants to merge 2 commits into
Open
umarjamilpc wants to merge 2 commits into
umarjamilpc wants to merge 2 commits into
Conversation
Allow optional WASAPI exclusive SPDIF passthrough for Dolby/DTS formats on Windows when connected to an AV receiver, with decoded PCM fallback when the toggle is off.
Resolve NativePlayerController create-path conflict with Dev's createWorker/nativeCreate lifecycle, keep HDMI passthrough arg, and update Linux JNI create signature plus teardown tests for parity.
Member
|
Looks good overall, but volume/speed are currently disabled whenever the setting is enabled, even if mpv falls back to decoded PCM. Please only disable them while passthrough is actually active, and rebase/test this against current Dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in Windows-only HDMI audio passthrough setting so Dolby/DTS bitstreams (including Atmos / DTS:X where the receiver supports them) can be sent unchanged over the Windows default HDMI endpoint via WASAPI exclusive + libmpv
audio-spdif. Default remains decoded PCM for speakers/headphones.Rebased onto current
Dev(0ce22855). One conflict resolved inPlayerEngine.desktop.kt(kept newinitialPositionMs/initialPositionRequestKeykeys and addedwindowsHdmiPassthroughEnabled).PR type
Why
Windows desktop currently always decodes to PCM, so AV receivers (e.g. Denon) see stereo/PCM instead of Dolby Atmos / DTS:X even when other Windows players bitstream correctly on the same HDMI path.
Feature request: #250 (open, labeled
enhancement; filed for maintainer review/approval per CONTRIBUTING).Desktop scope
audio-spdifpathcreatesignature parity only (unused bool)Issue or approval
Feature request: #250
UI / behavior impact
Policy check
CONTRIBUTING.md.Scope boundaries
Intentionally not included:
Testing
Devwith conflict resolution only inPlayerEngine.desktop.kt; no app rebuild in this update passcreate) and settings expect/actual stubs after rebaseScreenshots / Video
UI addition is a Windows-only Playback Settings switch (not a glitch fix). Happy to attach a settings screenshot on request.
Breaking changes
None when the toggle is left off (default). When enabled, software volume/speed are skipped while bitstreaming (receiver controls volume).
Linked issues
#250