Conversation
Merged
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macOS subtitle outline On/Off did not change the rendered subs. Custom styling only set
sub-outline-sizeand an ASSBold=override, so embeddedOutline/Shadowstayed. This PR makes outline apply, and adds a width control.What changed:
player_bridge.mm: when custom styling is on, also setsub-border-size,sub-border-color,sub-shadow-offset=0, and ASS style overridesBold=…,Outline=…,Shadow=0. Outline off now sends size0andOutline=0.outlineWidthto 1–8; persist was already there, it just had no UI.outlineWidth/subtitleOutlineWidthDelta.PR type
Primary fix is the macOS outline toggle not applying. Outline width is a small control on the same setting (
outlineWidthalready existed in storage).Why
User-visible bug: Style → Outline On/Off did not add or remove the subtitle border on macOS.
Expected: Off removes the border; On draws it. Width should be adjustable.
Desktop scope
player_bridge.mm) — this is the actual fix.NativePlayerControllerJSON.PlayerSettingsRepositoryclamp, playback settings slider, player eventsubtitleOutlineWidthDelta, English strings.Windows native bridge is unchanged (outline apply there still the old path). Android already used
outlineWidthin libmpv; the settings slider is now visible on all platforms because the setting is shared.Issue or approval
No linked issue: fix came from in-app testing of the outline toggle, not a GitHub issue. Happy to file one if maintainers want it linked.
UI / behavior impact
UI: outline width stepper in the player Style panel and a matching settings slider. No layout/theme redesign.
Policy check
CONTRIBUTING.md.No GitHub issue yet (see above). Screenshots/video not attached in this description.
Scope boundaries
player_bridge.cpp.Testing
Manual intent (macOS desktop, custom styling On):
Screenshots / Video
Not attached. UI addition is the outline width stepper/slider next to the existing outline toggle.
Breaking changes
None for config/schema. Possible visual diffs only with custom styling On:
Shadow=0can flatten ASS drop shadows.Outline=can change thickness vs the file’s embedded outline.Linked issues
No linked issue — outline toggle was broken on macOS in the player Style panel; width control uses the existing
outlineWidthsetting.