Conversation
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initialize cached authentication in the Desktop entry point before the first Compose frame, alongside the existing cached-profile preload.
This is the exact Desktop-only
Main.ktportion of the original implementation in NuvioDesktop PR #546, rebased onto the latestDev. The four sharedcommonMainchanges are intentionally submitted through companion NuvioMobile PR #1854.PR type
Why
Desktop already restores cached profiles synchronously before creating the Compose window, but cached authentication was initialized later from the shared app gate.
Preloading authentication beside the profile cache gives the first frame the complete restored startup state and avoids an unnecessary startup-state transition. The later shared initialization remains safe because
AuthRepository.initialize()is idempotent.Desktop scope
This changes only the shared Desktop entry point used by Windows, macOS, and Linux.
It does not modify
commonMainor native Mobile entry points. The related shared startup behavior is isolated in NuvioMobile PR #1854, following the maintainer direction recorded in NuvioDesktop PR #546.Issue or approval
Fixes #580
Original implementation and visual context: NuvioDesktop PR #546
Companion shared change: NuvioMobile PR #1854
UI / behavior impact
Policy check
CONTRIBUTING.md.Scope boundaries
Only
composeApp/src/desktopMain/kotlin/com/nuvio/app/Main.ktwas changed.No shared startup flow, UI implementation, dependencies, architecture, profile behavior, networking, or unrelated Desktop initialization was changed in this PR.
The newer startup-performance work already present in
Dev, including commit82310de4, is preserved.Testing
.\gradlew.bat --offline --console=plain :composeApp:compileKotlinDesktop.Screenshots / Video
Not a UI change.
The complete combined startup result and original before/after recordings are available in NuvioDesktop PR #546. Its four shared
commonMainfiles are now represented by companion NuvioMobile PR #1854.Breaking changes
None.
Linked issues
Fixes #580
Companion shared change: NuvioMobile PR #1854