Skip to content

feat(trailer): support background hero trailer playback on Windows desktop #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neerajlovecyber wants to merge 1 commit into
base: Dev
Choose a base branch
from
Open

feat(trailer): support background hero trailer playback on Windows desktop #598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions composeApp/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,8 +913,12 @@ val buildWindowsPlayerBridge = tasks.register<Exec>("buildWindowsPlayerBridge")
}
outputs.file(windowsPlayerBridgeOutput)
outputs.file(windowsPlayerBridgeImportLib)
outputs.file(windowsPlayerBridgePdb)
onlyIf { !windowsPlayerBridgeOutput.get().asFile.exists() }
val rebuildBridgeRequested = providers.gradleProperty("rebuildWindowsPlayerBridge").isPresent
onlyIf {
!windowsPlayerBridgeOutput.get().asFile.exists() ||
rebuildBridgeRequested ||
windowsPlayerBridgeSource.asFile.lastModified() > windowsPlayerBridgeOutput.get().asFile.lastModified()
}
commandLine(windowsPlayerBridgeCommand)
}

Expand Down
5 changes: 2 additions & 3 deletions composeApp/src/desktopMain/kotlin/com/nuvio/app/core/build/AppFeaturePolicy.desktop.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@ actual object AppFeaturePolicy {
actual val personalMediaAddonCopyEnabled: Boolean = false
actual val p2pEnabled: Boolean = true
actual val externalPlayerSupported: Boolean = false
actual val trailerPlaybackMode: TrailerPlaybackMode =
if (isWindowsDesktop) TrailerPlaybackMode.EXTERNAL else TrailerPlaybackMode.IN_APP
actual val heroTrailerPlaybackSupported: Boolean = !isWindowsDesktop
actual val trailerPlaybackMode: TrailerPlaybackMode = TrailerPlaybackMode.IN_APP
actual val heroTrailerPlaybackSupported: Boolean = true
actual val inAppUpdaterEnabled: Boolean = true
actual val imdbRatingLogoEnabled: Boolean = true
actual val mediaPlaybackForegroundServiceEnabled: Boolean = false
Expand Down
46 changes: 17 additions & 29 deletions ...rc/desktopMain/kotlin/com/nuvio/app/features/trailer/TrailerExtractionPlatform.desktop.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,11 @@ internal object TrailerExtractionPlatform {
.followSslRedirects(true)
.build()

fun supportsSeparateVideo(candidate: StreamCandidate): Boolean = candidate.ext == "mp4"
fun supportsSeparateVideo(candidate: StreamCandidate): Boolean =
if (com.nuvio.app.isWindows) true else candidate.ext == "mp4"

fun supportsSeparateAudio(candidate: StreamCandidate): Boolean = candidate.ext == "m4a"
fun supportsSeparateAudio(candidate: StreamCandidate): Boolean =
if (com.nuvio.app.isWindows) true else candidate.ext == "m4a"

fun diagnostic(message: String) {
if (diagnosticsEnabled) {
Expand Down Expand Up @@ -101,7 +103,7 @@ internal object TrailerExtractionPlatform {
val bestCombinedIsManifest = bestManifest != null &&
(bestProgressive == null || bestManifest.height > bestProgressive.height)
val preferManifestPlayback = bestManifest != null &&
(bestVideo == null || bestManifest.height >= bestVideo.height)
(bestVideo == null || (bestManifest.height >= bestVideo.height && !com.nuvio.app.isWindows))
val combinedUrl = if (bestCombinedIsManifest) {
bestManifest.manifestUrl
} else {
Expand Down Expand Up @@ -206,7 +208,7 @@ internal object TrailerExtractionPlatform {
}

return try {
val selected = withTimeoutOrNull(4_000L) { result.await() }
val selected = withTimeoutOrNull(2_000L) { result.await() }
diagnostic(
"probe ${if (selected != null) "ok" else "failed"} ${describeUrl(url)} candidates=${candidates.size}" +
selected?.let { " selectedHost=${it.toHttpUrlOrNull()?.host ?: "unknown"}" }.orEmpty(),
Expand All @@ -218,33 +220,19 @@ internal object TrailerExtractionPlatform {
}

private fun isUrlReachable(url: String): Boolean = runCatching {
val parsedUrl = url.toHttpUrlOrNull()
val sourceSize = parsedUrl?.queryParameter("clen")?.toLongOrNull()?.takeIf { it > 0L }
val ranges = sourceSize?.let { size ->
listOf(
0L to 65_535L.coerceAtMost(size - 1L),
(size - 65_536L).coerceAtLeast(0L) to size - 1L,
).distinct()
} ?: listOf(0L to 0L)

ranges.all { (rangeStart, rangeEnd) ->
val request = Request.Builder()
.url(url)
.headers(buildHeaders(defaultHeaders))
.header("Range", "bytes=$rangeStart-$rangeEnd")
.get()
.build()
val request = Request.Builder()
.url(url)
.headers(buildHeaders(defaultHeaders))
.header("Range", "bytes=0-0")
.get()
.build()

probeClient.newCall(request).execute().use { response ->
val reachable = response.code == 206 ||
(sourceSize == null && rangeStart == 0L && response.code in 200..299)
if (!reachable) {
diagnostic(
"probe range rejected ${describeUrl(url)} requested=$rangeStart-$rangeEnd status=${response.code}",
)
}
reachable
probeClient.newCall(request).execute().use { response ->
val reachable = response.isSuccessful || response.code == 206
if (!reachable) {
diagnostic("probe range rejected ${describeUrl(url)} status=${response.code}")
}
reachable
}
}.getOrDefault(false)

Expand Down
Loading
Loading