fix(home): scale entire continue watching card on desktop hover - #600
Open
neerajlovecyber wants to merge 1 commit into
Open
neerajlovecyber wants to merge 1 commit into
neerajlovecyber wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the hover animation on Continue Watching landscape cards so the entire card scales up smoothly (1.05x) and elevates above neighboring cards, consistent with all other desktop catalog cards (
NuvioPosterCard,CollectionCard,ContinueWatchingWideCard, etc.).Previously,
.clip(RoundedCornerShape(...))was chained before.posterCardClickable(...), trapping the hovergraphicsLayerscale inside the unscaled card boundaries. As a result, hovering would zoom and crop the inner image rather than scaling the entire card. Moving.posterCardClickable(...)to the start of the modifier chain allows the entire card to expand on hover.PR type
Why
In the desktop Continue Watching row, hovering over landscape cards resulted in the inner artwork zooming in place while the card frame remained stationary. All other cards across the app grow outwards when hovered. Placing
.posterCardClickable(...)before.clip()fixes the modifier execution order so the card scales as expected.Desktop scope
Desktop app (
commonMainlayout componentContinueWatchingLandscapeCard). Affects Windows, macOS, and Linux desktop builds where desktop hover scaling is enabled. On touch-based mobile devices,desktopPosterHoverScaleis a no-op (if (!isDesktop) return this).Issue or approval
Fixes #599
UI / behavior impact
Policy check
CONTRIBUTING.md.Scope boundaries
ContinueWatchingLandscapeCardinHomeContinueWatchingSection.kt.Testing
Nuvio.exe): hovering over Continue Watching landscape cards now smoothly expands the entire card (1.05x) and elevates above adjacent cards.Screenshots / Video
Verified on desktop: Continue Watching landscape cards smoothly scale up the whole card container on mouse hover instead of zooming the inner image inside a stationary frame.


Breaking changes
None.
Linked issues
Fixes #599