Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed default behavior of volume boost PR to allow volume boost using keyboard/mouse wheel
PR type
Why
Judging by Discord, this is a controversial topic.
At first I was against it, but after checking out MPV and VLC players, they both have this behaviour by default, where user can go beyond 100% freely and without being alerted.
Desktop scope
Desktop shared code
Issue or approval
Fixes #618
UI / behavior impact
Policy check
CONTRIBUTING.md.Scope boundaries
Does not include extra UI polish. Only changed default behavior of volume booster.
Testing
Screenshots / Video
Sorry about video missing sound.
volume.mp4
Breaking changes
None
Linked issues
Fix #618