feat(settings): add comprehensive shortcuts screen to show all added shortcuts in one player - #633
AdityasahuX07 wants to merge 14 commits into
Conversation
|
from tapframe: |
Note - #639 is related with this PR. |
|
please move all hardcoded user-facing text in the shortcuts page to string resources, and strip the embedded C2PA/Claude metadata from the mouse SVGs. |
Removed backspace shortcut from the shortcuts settings.
Added new strings for custom themes and shortcuts.
Done. |
|
Thanks, the latest version now builds successfully and the M4/M5 SVGs are clean.
|
Removed several theme strings and a backspace key string from the XML resource file.
Done. |
This workflow builds the Nuvio Desktop PR NuvioMedia#633 for Windows x64, verifying the source, setting up the environment, and packaging the application into an MSI installer.
|
What do you think about this implementation instead of yours? rewrite-shortcuts Give it a try if you want |
I gave rewrite-shortcuts a thorough look. I think your implementation is a better foundation than my current shortcut implementation, especially because it introduces a proper centralized, user-configurable shortcut system with persistence, conflict detection, and player integration. But the some shortcuts are missing that must add before push to dev branch.
A few important player actions are missing I added bellow: Audio -
Playback Speed -
Subtitle -
|
|
I removed some of shortcuts by intent because they're making it complicated like for every action we dont need a shortcut It's just extra code and I dont get why we should add mouse shortcuts, shortcuts meant for keyboard because you have lots of keys mouse you have mouse1 and mouse2 sometimes mouse4 and mouse5 which is limited and mouse4 and mouse5 intent is always forward and back and i didnt added every shortcut in there because nobody cares about things like "Mouse1 to play/pause" like that's already a thing. |
I totally agree for we dont need too many shortcuts. Also drop the mouse configuration to make it simple. Since the some shortcut removal is intended. But I do believe some important shortcut is missing please add those keyboard shortcuta I narrow down the previous missing shortcut lists and revised with only most frequently used shortcut,
|
|
I agree 2 is useless that just added to make symmetric because the subtitle window is added 4 is good addtion if we add 50ms +/- because when we adjust via ui it cover the complete screen so multiple times we have to required open close the aub delay window. When the shortcut added it will be easy to adjust |


Summary
Added a dedicated "Shortcuts" settings page that provides a comprehensive overview of keyboard and mouse shortcuts. This includes custom mouse SVG icons, uniform Material vector arrows for directional inputs, and a navigation bypass on tablet/desktop layouts to immediately open the Shortcuts page from the sidebar rather than requiring an extra click through a mediator sub-menu.
PR type
Why
The application lacked a centralized way for users to view and reference keyboard and mouse shortcuts. This implements a clean UI with proper custom SVG icons, correctly sequenced shortcut preferences (e.g., M4/M5 assigned to Forward/Backward, uniform vector chevrons replacing inconsistent text symbols), and significantly improves navigation flow by directly routing to the page from the settings sidebar on desktop layouts.
Desktop scope
Affects desktop shared code (
composeApp/src/commonMain). Navigation routing improvements apply to desktop layouts utilizing the sidebar (TabletSettingsScreen), while the new Shortcuts UI page is implemented in common Compose Multiplatform code.Issue or approval
Fixes #634
UI / behavior impact
Policy check
CONTRIBUTING.md.Scope boundaries
This PR strictly adds the shortcuts visual page and its navigation routing. It does not alter the underlying keyboard/mouse event handling logic or actual runtime playback shortcut behavior.
Testing
Tested locally on Windows 11 Desktop (
desktopMain).mouse_m4_button_16, etc.) scale correctly inside keycaps.KeyboardArrowvector icons render uniformly across OS fonts.ShortcutsSettingsPagewithout rendering the intermediate mediator menu../gradlew desktopMainClasses.Screenshots / Video
Breaking changes
None
Linked issues
Fixes #634