feat: per-platform providers, independent sessions, personalised discover - #7
Merged
Merged
Conversation
- generate BuildConfig from WREN_GOOGLE_CLIENT_ID/SECRET env vars so releases ship a desktop OAuth client; ~/.config/wren/oauth.json stays as an override. CI distro jobs read the values from repo secrets - add jdk.jsobject and jdk.xml.dom to the jlinked runtime: javafx-web requires them and the packaged app crashed on WebView creation - build-appimage.sh resolves a JDK 21 via mise, runs the Kotlin compiler in-process (daemon rejects 4-part JDK versions) and writes the image through a temp file so a running AppImage no longer blocks the build - ignore squashfs-root/ and client_secret*.json
…ions - replace AuthManager with AuthStore (profile + per-provider session files), GoogleAuth and SoundCloudAuth; AuthEvents lets Compose observe connect/disconnect without the auth layer depending on the UI - Google: ephemeral loopback port, cancellable accept and single-flight listener fix "Address already in use" on retries; open the browser via Desktop, $BROWSER or xdg-open with a copy-link fallback in the dialog - SoundCloud: native PKCE flow against secure.soundcloud.com using the scraped web client id; only the authorization page runs in the JavaFX WebView, the callback is intercepted and the code exchanged natively. Toolkit started once, popup handler and desktop UA for social logins, refresh token stored and refreshed near expiry - ProfileDialog manages both sessions; AuthDialog removed - main.kt: detect compositor scale (Hyprland, GDK_SCALE, Xft.dpi) so the UI renders at native resolution under fractional scaling
…irlines - add FFmpegPlayer.jumpTo so clicking a queue row keeps the current order; loadQueue reshuffled and played a random track under shuffle - plain lyrics carry no timestamps and render static; the fake 4s cadence highlighted and auto-scrolled lines that were never synced - auto-scroll yields to the user for 6s after a manual scroll (lyrics and queue); constant lyric font size removes the jitter - progress bar seeks on click/drag with a live scrub label - explicit artwork accepted at any size, image fetch has timeouts, lyrics fetch keyed on the metadata it sends - theme-aware Hairline tokens replace hard-coded black separators
- MusicProvider abstraction (search, artists, station, discover,
library) with YouTubeProvider and SoundCloudProvider; a YT/SC switcher
in the sidebar scopes Search, Discover and Library while the queue
stays shared. Cross-platform search merging is gone
- SoundCloud: api-v2 calls carry the session token; Discover shows
mixed-selections ("Made for you", curated, trending) as collection
cards plus the local weekly list; stations use the real station
endpoint; Library lists likes and own playlists, hydrating id stubs
through /tracks?ids
- YouTube: per-track radio via the RDAMVM mix on the next endpoint;
Discover offers one radio per recently played track
- PlaylistTrack and ListeningHistory carry their source; sidebar profile
row always opens the profile dialog so either session can be added
- YouTube has no discovery feed reachable with the Data API scope; the tab is Wren's own construct (radios seeded by local plays), so the provider now owns the tab label and the empty-state hint and says so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separates YouTube and SoundCloud into providers, gives the profile independent sessions for each, and fixes the SoundCloud login and Now Playing defects.
WREN_GOOGLE_CLIENT_ID/SECRET(CI reads repo secrets), addjdk.jsobject/jdk.xml.domto the jlinked runtime so the WebView works in packaged builds, AppImage script resolves JDK 21 via mise and survives a running instance.AuthStorewith a local profile and per-provider session files;GoogleAuthandSoundCloudAuth;AuthEventsfor reactive UI. Google login uses an ephemeral loopback port with a cancellable, single-flight listener and a robust browser opener. SoundCloud login is a native PKCE flow againstsecure.soundcloud.comwith only the authorization page in the JavaFX WebView; the callback is intercepted and exchanged natively, refresh token stored.AuthDialogremoved in favour ofProfileDialog.jumpTo), plain lyrics render static, auto-scroll yields to the user, seekable progress bar, artwork/timeouts, theme-aware hairlines.MusicProviderwithYouTubeProviderandSoundCloudProvider; YT/SC switcher in the sidebar scopes Search, Discover and Library while the queue stays shared. SoundCloud calls carry the session token: Discover shows mixed-selections as collection cards plus the local weekly list, stations use the real endpoint, Library lists likes and playlists. YouTube gets per-track radio via theRDAMVMmix; its second tab is named "radios" since YouTube exposes no discovery feed.Test plan
./gradlew :desktop:testgreen (new tests for SoundCloud OAuth, collections, YT radio parser, AuthStore)oauth.json)Known limitation: "Continue with Google" inside the SoundCloud window stays blank — JavaFX WebKit cannot deliver Google's named-popup form submission. Email/password login works; a Chromium embed (KCEF) would be needed for social logins.
🤖 Generated with Claude Code