Skip to content

[18.0][IMP] automation_oca: inform context comparaison with base_automation#43

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
TechnoLibre:18.0-automation_oca_improve_readme
Jan 28, 2026
Merged

[18.0][IMP] automation_oca: inform context comparaison with base_automation#43
OCA-git-bot merged 1 commit intoOCA:18.0from
TechnoLibre:18.0-automation_oca_improve_readme

Conversation

@mathben
Copy link
Contributor

@mathben mathben commented Jan 26, 2026

#42
Do you like this description @etobella ?
How this generate the readme.rst?

@mathben mathben changed the title [ADD] automation_oca: inform context comparaison with base_automation [18.0][ADD] automation_oca: inform context comparaison with base_automation Jan 26, 2026
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Looks good, but define a file called CONTEXT.md on the readme folder and the process will be handled automatically 😉

https://github.com/OCA/maintainer-tools/blob/master/tools/gen_addon_readme.py#L41

@mathben mathben force-pushed the 18.0-automation_oca_improve_readme branch 2 times, most recently from bb58e7d to c4b6265 Compare January 26, 2026 11:35
@mathben
Copy link
Contributor Author

mathben commented Jan 26, 2026

I add this comment about external events such as email interactions

#42 (comment)

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great documentation
Thanks
LGTM

@pedrobaeza pedrobaeza added this to the 18.0 milestone Jan 27, 2026
@pedrobaeza
Copy link
Member

Thanks for the PR. We need more of these that add knowledge value. Just one thing: please name it with [IMP], not [ADD], as this is not adding a module, but improving an existing one. It's very usual that people associates adding things with [ADD], but if you think twice, a patch/bugfix can also add lines of code, so we restrict the meaning of the label to add modules, as if not, mostly everything may have it.

@mathben mathben force-pushed the 18.0-automation_oca_improve_readme branch from c4b6265 to 983ccb0 Compare January 27, 2026 08:42
@mathben mathben changed the title [18.0][ADD] automation_oca: inform context comparaison with base_automation [18.0][IMP] automation_oca: inform context comparaison with base_automation Jan 27, 2026
@mathben
Copy link
Contributor Author

mathben commented Jan 28, 2026

@pedrobaeza Done, thanks for the explication.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-43-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b5ecdc5 into OCA:18.0 Jan 28, 2026
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 27fc2bb. Thanks a lot for contributing to OCA. ❤️

@mathben mathben deleted the 18.0-automation_oca_improve_readme branch January 28, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants