Skip to content

[18.0][MIG] sms_no_alter_body: Migration to 18.0#357

Open
FranzPoize wants to merge 5 commits intoOCA:18.0from
akretion:18.0-mig-sms_no_alter_body
Open

[18.0][MIG] sms_no_alter_body: Migration to 18.0#357
FranzPoize wants to merge 5 commits intoOCA:18.0from
akretion:18.0-mig-sms_no_alter_body

Conversation

@FranzPoize
Copy link

No description provided.

@FranzPoize FranzPoize force-pushed the 18.0-mig-sms_no_alter_body branch from 86b2964 to 84ac8de Compare November 21, 2025 17:45
@FranzPoize FranzPoize marked this pull request as ready for review November 21, 2025 17:51
Copy link

@metaminux metaminux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @FranzPoize

I think we can merge administrative commits here :

  • merge the 5 first commits to the [ADD]
  • merge the 2 commits for Spanish translation together
  • merge the 4 commits for Italian translation together

See https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

Regards,

@FranzPoize FranzPoize force-pushed the 18.0-mig-sms_no_alter_body branch from 84ac8de to cb49878 Compare February 25, 2026 10:11
@FranzPoize FranzPoize force-pushed the 18.0-mig-sms_no_alter_body branch from cb49878 to c8c56a9 Compare February 26, 2026 09:03
Comment on lines +9 to +14
def setUpClass(self):
super().setUpClass()
self.partner = self.env["res.partner"].create(
{"name": "FOO", "mobile": "+3360707070707"}
)

Copy link

@metaminux metaminux Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this should make the tests green again...

Suggested change
def setUpClass(self):
super().setUpClass()
self.partner = self.env["res.partner"].create(
{"name": "FOO", "mobile": "+3360707070707"}
)
@classmethod
def setUpClass(cls):
super().setUpClass()
cls.partner = cls.env["res.partner"].create(
{"name": "FOO", "mobile": "+33607070707"}
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants