[15.0][MIG] connector_base_product: Migration to 15.0

[flachica]

Related PRs on the same subject

OCA/sale-workflow#2005
OCA/connector-prestashop#151
OCA/connector-ecommerce#70
OCA/server-tools#2334
OCA/product-attribute#1070
OCA/product-attribute#1069

[flachica]

I can't solve the runboat error. Can someone give me a clue /cc @guewen

[flachica]

I can't solve the runboat error. Can someone give me a clue /cc @guewen

Finally, after accepting other dependent PRs, they have passed the tests

[john-herholz-dt]

What is missing here?

[flachica]

What is missing here?

Is needed two reviewers and one PSC can accept the PR

[rvalyi]

Hello @flachica I have no problem with your change and I believe it is correct. However, the checks won't pass because the CI metafiles are not up to date in this v15 connector repo. The runbot is decommissioned and replaced by runboat. Somebody should remove the .travis.yml and add a github action folder like .github/workflows
all metafiles can be seen in https://github.com/OCA/maintainer-quality-tools

Once a PR is made to fix these metafiles, I would say you could rebase your PR and if checks pass it will have more chances to be merged (I would approve it at least).

[flachica]

Hello @flachica I have no problem with your change and I believe it is correct. However, the checks won't pass because the CI metafiles are not up to date in this v15 connector repo. The runbot is decommissioned and replaced by runboat. Somebody should remove the .travis.yml and add a github action folder like .github/workflows all metafiles can be seen in https://github.com/OCA/maintainer-quality-tools

Once a PR is made to fix these metafiles, I would say you could rebase your PR and if checks pass it will have more chances to be merged (I would approve it at least).

All done! Thanks for your review @rvalyi

[flachica]

Any problem with this PR?

[simahawk]

/ocabot migration connector_base_product

[simahawk]

commits are messed up, please rebase and keep the mig changes in the last one, thanks!

[flachica]

commits are messed up, please rebase and keep the mig changes in the last one, thanks!

Rebase done, thanks!

[simahawk]

the 1st commit is still wrong. Contains migration changes 1e5d87f
I'd rollback the 2 commits and stage only what's needed manually.

[flachica]

I migrated the module step by step. Forced push the changes. Can review, please @simahawk

[simahawk]

@flachica better now. Can you rewrite the commit msg to connector_base_product: Migration to 15.0? Thanks!

[flachica]

@flachica better now. Can you rewrite the commit msg to connector_base_product: Migration to 15.0? Thanks!

Done

[simahawk]

"Migration to 15.0" of what? As per guidelines and per my msg above, pls include the module name 🙏

[flachica]

"Migration to 15.0" of what? As per guidelines and per my msg above, pls include the module name pray

Re done

[flachica]

@simahawk One question, what guidelines are you referring to?

[simahawk]

Search for "OCA migration guidelines" and you should land on these pages

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0
https://github.com/OCA/maintainer-tools/wiki#migration
https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst

[flachica]

In order to finish migrating the Prestashop connector I need this PR to be merged. It has one approval. Any PSC check it out? /cc @simahawk @gurneyalex

[asierneiradev]

Good job @flachica !
Hopefully it will soon be revised and can be merged

[flachica]

Hi @asierneiradev. To be merged this PR needs one more review. Please, click on Files changed and submit your review

[john-herholz-dt]

Finally!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[rafaelbn]

Here you are @simahawk ! 😄 final review in order to get this merge! 👍

[simahawk]

Dependency below, please review

OCA/sale-workflow#2005 OCA/connector-prestashop#151 OCA/connector-ecommerce#70 OCA/server-tools#2334 OCA/product-attribute#1070 OCA/product-attribute#1069

@flachica please do not mention all these PRs in all PRs as "dependencies".
They are "related" but they do not depend on each other.

If you do so, ppl will expect to review those PRs first to unlock this one. Or, like in my case, I will not merge at first because I'll see those pending links and I'll have to spend some time understanding that they are actually not blocking at all.
Please, clean them up or make these references more clear.

Thanks for your understanding!

[simahawk]

/ocabot merge nobump

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-428-by-simahawk-bump-nobump, awaiting test results.

[OCA-git-bot]

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-428-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[simahawk]

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-428-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

we need this #455

[simahawk]

Merged, can you rebase pls?

[flachica]

Thanks for your work @simahawk. Rebased

[simahawk]

/ocabot merge nobump

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-428-by-simahawk-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 4d35651. Thanks a lot for contributing to OCA. ❤️