[16.0][IMP] cooperator_website: Improve placeholders#181
Open
cesarlr wants to merge 1 commit into
Open
Conversation
Author
huguesdk
changed the title
huguesdk
requested changes
Jun 26, 2026
Member
There was a problem hiding this comment.
thanks for this, @cesarlr! this feature is actually in the planning of the coming weeks at coop it easy.
some remarks:
- for empty placeholders, the attribute should simply be removed.
- firstname and lastname actually don’t require placeholders.
- email adresses don’t require placeholders either (the form label is clear enough), and the input type
emailwill anyway make the browser help the user in case of invalid input.
please use the [IMP] tag in your commit message, as explained in the coding guidelines.
| t-att-readonly="logged" | ||
| t-att-value="phone" | ||
| placeholder="+32 456 926 5059" | ||
| placeholder="" |
Member
There was a problem hiding this comment.
this placeholder is still useful to tell people to use the international format. maybe something more generic, like +12 345 67 89 01?
| required="true" | ||
| t-att-value="company_email" | ||
| placeholder="administration@mycoop.be" | ||
| placeholder="administration@example.org" |
Member
There was a problem hiding this comment.
this can be removed, but the input type should be email.
| t-att-readonly="logged" | ||
| t-att-value="confirm_email" | ||
| placeholder="administration@mycoop.be" | ||
| placeholder="administration@example.org" |
Member
There was a problem hiding this comment.
same remark as above, especially since the input type here has actually an invalid value: it should be email, not confirm_email.
cesarlr
force-pushed
the
16.0-improve-placeholders
branch
from
80b3c93 to
e83620d
Compare
cesarlr
force-pushed
the
16.0-improve-placeholders
branch
from
e83620d to
9a5f88b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.