[12.0][ADD] cooperator_website_recaptcha#43
Conversation
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
co-authored-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
* move the recaptcha widget view to portal_recaptcha. * remove res.company.captcha_type (portal_recaptcha can now be enabled and disabled in the settings). * override WebsiteSubscription._additional_validate() instead of .validation().
fix author and website manifest properties to follow oca's guidelines.
huguesdk
force-pushed
the
12.0-add-cooperator_website_recaptcha
branch
3 times, most recently
from
f5bb090 to
bc505e9
Compare
carmenbianca
left a comment
carmenbianca
left a comment
There was a problem hiding this comment.
LGTM
Side-note: There's no need to compile README.rst in your PRs. It is generated as a side effect of the ocabot merge command.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
|
@robinkeunen would you please re-open this pr? |
github-actions
Bot
removed
the
stale
|
@huguesdk I wonder if we should spend time merging this refacto on 12 (plus the refacto of portal_recaptcha). We will merge it in 14 and then port it to 16. What do you think ? |
|
@victor-champonnois as it is a module that is used in production by many clients and is one of the last ones that is still in coopiteasy/vertical-cooperative, i think it makes sense to complete this, to have the most used modules here in OCA/cooperative. moreover, it does not require much more work. the only problem is that OCA/website#914, on which it depends, is not yet merged, and i don’t know if it ever will. let’s first work on getting the 14.0 version merged, then adapt the 12.0 version if it still makes sense at that time. @robinkeunen: would you please apply the “no stale” label to this to ensure that it does not get automatically closed? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
huguesdk
added
no stale
5 participants
move
cooperator_website_recaptchamodule from coopiteasy/vertical-cooperative to the oca.this branch contains an extra refactoring commit (from the 12.0-ref-cooperator_website_recaptcha_to_portal_recaptcha branch) that should be reviewed. this refactoring depends on #40 and OCA/website#914.