OCA · sundar-prakash · Jan 24, 2022 · Jan 24, 2022 · Feb 7, 2022 · Mar 1, 2022
diff --git a/.copier-answers.yml b/.copier-answers.yml
diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml
@@ -3,11 +3,11 @@ name: pre-commit
 on:
   pull_request:
     branches:
-      - "19.0*"
+      - "18.0*"
   push:
     branches:
-      - "19.0"
-      - "19.0-ocabot-*"
+      - "18.0"
+      - "18.0-ocabot-*"
 
 jobs:
   pre-commit:

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -3,11 +3,11 @@ name: tests
 on:
   pull_request:
     branches:
-      - "19.0*"
+      - "18.0*"
   push:
     branches:
-      - "19.0"
-      - "19.0-ocabot-*"
+      - "18.0"
+      - "18.0-ocabot-*"
 
 jobs:
   unreleased-deps:
@@ -35,14 +35,14 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - container: ghcr.io/oca/oca-ci/py3.10-odoo19.0:latest
+          - container: ghcr.io/oca/oca-ci/py3.10-odoo18.0:latest
             name: test with Odoo
-          - container: ghcr.io/oca/oca-ci/py3.10-ocb19.0:latest
+          - container: ghcr.io/oca/oca-ci/py3.10-ocb18.0:latest
             name: test with OCB
             makepot: "true"
     services:
       postgres:
-        image: postgres:13
+        image: postgres:12.0
         env:
           POSTGRES_USER: odoo
           POSTGRES_PASSWORD: odoo

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -39,11 +39,11 @@ repos:
         language: fail
         files: '[a-zA-Z0-9_]*/i18n/en\.po$'
   - repo: https://github.com/sbidoul/whool
-    rev: v1.3
+    rev: v1.2
     hooks:
       - id: whool-init
   - repo: https://github.com/oca/maintainer-tools
-    rev: f9b919b9868143135a9c9cb03021089cabba8223
+    rev: bf9ecb9938b6a5deca0ff3d870fbd3f33341fded
     hooks:
       # update the NOT INSTALLABLE ADDONS section above
       - id: oca-update-pre-commit-excluded-addons
@@ -52,15 +52,15 @@ repos:
       - id: oca-gen-addon-readme
         args:
           - --addons-dir=.
-          - --branch=19.0
+          - --branch=18.0
           - --org-name=OCA
           - --repo-name=dms
           - --if-source-changed
           - --keep-source-digest
           - --convert-fragments-to-markdown
       - id: oca-gen-external-dependencies
   - repo: https://github.com/OCA/odoo-pre-commit-hooks
-    rev: v0.1.6
+    rev: v0.0.33
     hooks:
       - id: oca-checks-odoo-module
       - id: oca-checks-po
@@ -79,8 +79,8 @@ repos:
         files: \.(css|htm|html|js|json|jsx|less|md|scss|toml|ts|xml|yaml|yml)$
         language: node
         additional_dependencies:
-          - "prettier@3.6.2"
-          - "@prettier/plugin-xml@3.4.2"
+          - "prettier@3.3.3"
+          - "@prettier/plugin-xml@3.4.1"
   - repo: local
     hooks:
       - id: eslint
@@ -93,11 +93,11 @@ repos:
         types: [javascript]
         language: node
         additional_dependencies:
-          - "eslint@9.35.0"
-          - "eslint-plugin-jsdoc@57.0.8"
+          - "eslint@9.12.0"
+          - "eslint-plugin-jsdoc@50.3.1"
           - "globals@16.0.0"
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v6.0.0
+    rev: v4.6.0
     hooks:
       - id: trailing-whitespace
         # exclude autogenerated files
@@ -106,6 +106,8 @@ repos:
         # exclude autogenerated files
         exclude: /README\.rst$|\.pot?$
       - id: debug-statements
+      - id: fix-encoding-pragma
+        args: ["--remove"]
       - id: check-case-conflict
       - id: check-docstring-first
       - id: check-executables-have-shebangs
@@ -117,13 +119,13 @@ repos:
       - id: mixed-line-ending
         args: ["--fix=lf"]
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.13.0
+    rev: v0.6.8
     hooks:
       - id: ruff
         args: [--fix, --exit-non-zero-on-fix]
       - id: ruff-format
   - repo: https://github.com/OCA/pylint-odoo
-    rev: v9.3.15
+    rev: v9.1.3
     hooks:
       - id: pylint_odoo
         name: pylint with optional checks

diff --git a/.pylintrc b/.pylintrc
@@ -10,7 +10,7 @@ manifest-required-authors=Odoo Community Association (OCA)
 manifest-required-keys=license
 manifest-deprecated-keys=description,active
 license-allowed=AGPL-3,GPL-2,GPL-2 or any later version,GPL-3,GPL-3 or any later version,LGPL-3
-valid-odoo-versions=19.0
+valid-odoo-versions=18.0
 
 [MESSAGES CONTROL]
 disable=all
@@ -23,12 +23,21 @@ disable=all
 # config as a blocking check.
 
 enable=anomalous-backslash-in-string,
+    api-one-deprecated,
+    api-one-multi-together,
     assignment-from-none,
     attribute-deprecated,
+    class-camelcase,
     dangerous-default-value,
+    dangerous-view-replace-wo-priority,
     development-status-allowed,
+    duplicate-id-csv,
     duplicate-key,
+    duplicate-xml-fields,
+    duplicate-xml-record-id,
+    eval-referenced,
     eval-used,
+    incoherent-interpreter-exec-perm,
     license-allowed,
     manifest-author-string,
     manifest-deprecated-key,
@@ -39,57 +48,57 @@ enable=anomalous-backslash-in-string,
     method-inverse,
     method-required-super,
     method-search,
+    openerp-exception-warning,
     pointless-statement,
     pointless-string-statement,
     print-used,
     redundant-keyword-arg,
+    redundant-modulename-xml,
     reimported,
+    relative-import,
     return-in-init,
+    rst-syntax-error,
     sql-injection,
     too-few-format-args,
     translation-field,
     translation-required,
     unreachable,
     use-vim-comment,
+    wrong-tabs-instead-of-spaces,
+    xml-syntax-error,
     attribute-string-redundant,
+    character-not-valid-in-resource-link,
     consider-merging-classes-inherited,
     context-overridden,
+    create-user-wo-reset-password,
+    dangerous-filter-wo-user,
+    dangerous-qweb-replace-wo-priority,
+    deprecated-data-xml-node,
+    deprecated-openerp-xml-node,
+    duplicate-po-message-definition,
     except-pass,
+    file-not-used,
     invalid-commit,
     manifest-maintainers-list,
+    missing-newline-extrafiles,
     missing-readme,
     missing-return,
     odoo-addons-relative-import,
+    old-api7-method-defined,
+    po-msgstr-variables,
+    po-syntax-error,
     renamed-field-parameter,
     resource-not-exist,
+    str-format-used,
     test-folder-imported,
     translation-contains-variable,
     translation-positional-used,
+    unnecessary-utf8-coding-comment,
     website-manifest-key-not-valid-uri,
+    xml-attribute-translatable,
+    xml-deprecated-qweb-directive,
+    xml-deprecated-tree-attribute,
     external-request-timeout,
-    bad-builtin-groupby,
-    category-allowed,
-    deprecated-name-get,
-    deprecated-odoo-model-method,
-    inheritable-method-lambda,
-    inheritable-method-string,
-    invalid-email,
-    manifest-behind-migrations,
-    manifest-data-duplicated,
-    missing-odoo-file,
-    no-raise-unlink,
-    no-search-all,
-    no-wizard-in-models,
-    prohibited-method-override,
-    prefer-env-translation,
-    translation-format-interpolation,
-    translation-format-truncated,
-    translation-fstring-interpolation,
-    translation-not-lazy,
-    translation-too-few-args,
-    translation-too-many-args,
-    translation-unsupported-format,
-    no-write-in-compute,
     # messages that do not cause the lint step to fail
     consider-merging-classes-inherited,
     create-user-wo-reset-password,
@@ -105,8 +114,7 @@ enable=anomalous-backslash-in-string,
     old-api7-method-defined,
     redefined-builtin,
     too-complex,
-    unnecessary-utf8-coding-comment,
-    manifest-external-assets
+    unnecessary-utf8-coding-comment
 
 
 [REPORTS]

diff --git a/.pylintrc-mandatory b/.pylintrc-mandatory
@@ -9,18 +9,27 @@ manifest-required-authors=Odoo Community Association (OCA)
 manifest-required-keys=license
 manifest-deprecated-keys=description,active
 license-allowed=AGPL-3,GPL-2,GPL-2 or any later version,GPL-3,GPL-3 or any later version,LGPL-3
-valid-odoo-versions=19.0
+valid-odoo-versions=18.0
 
 [MESSAGES CONTROL]
 disable=all
 
 enable=anomalous-backslash-in-string,
+    api-one-deprecated,
+    api-one-multi-together,
     assignment-from-none,
     attribute-deprecated,
+    class-camelcase,
     dangerous-default-value,
+    dangerous-view-replace-wo-priority,
     development-status-allowed,
+    duplicate-id-csv,
     duplicate-key,
+    duplicate-xml-fields,
+    duplicate-xml-record-id,
+    eval-referenced,
     eval-used,
+    incoherent-interpreter-exec-perm,
     license-allowed,
     manifest-author-string,
     manifest-deprecated-key,
@@ -31,57 +40,57 @@ enable=anomalous-backslash-in-string,
     method-inverse,
     method-required-super,
     method-search,
+    openerp-exception-warning,
     pointless-statement,
     pointless-string-statement,
     print-used,
     redundant-keyword-arg,
+    redundant-modulename-xml,
     reimported,
+    relative-import,
     return-in-init,
+    rst-syntax-error,
     sql-injection,
     too-few-format-args,
     translation-field,
     translation-required,
     unreachable,
     use-vim-comment,
+    wrong-tabs-instead-of-spaces,
+    xml-syntax-error,
     attribute-string-redundant,
+    character-not-valid-in-resource-link,
     consider-merging-classes-inherited,
     context-overridden,
+    create-user-wo-reset-password,
+    dangerous-filter-wo-user,
+    dangerous-qweb-replace-wo-priority,
+    deprecated-data-xml-node,
+    deprecated-openerp-xml-node,
+    duplicate-po-message-definition,
     except-pass,
+    file-not-used,
     invalid-commit,
     manifest-maintainers-list,
+    missing-newline-extrafiles,
     missing-readme,
     missing-return,
     odoo-addons-relative-import,
+    old-api7-method-defined,
+    po-msgstr-variables,
+    po-syntax-error,
     renamed-field-parameter,
     resource-not-exist,
+    str-format-used,
     test-folder-imported,
     translation-contains-variable,
     translation-positional-used,
+    unnecessary-utf8-coding-comment,
     website-manifest-key-not-valid-uri,
-    external-request-timeout,
-    bad-builtin-groupby,
-    category-allowed,
-    deprecated-name-get,
-    deprecated-odoo-model-method,
-    inheritable-method-lambda,
-    inheritable-method-string,
-    invalid-email,
-    manifest-behind-migrations,
-    manifest-data-duplicated,
-    missing-odoo-file,
-    no-raise-unlink,
-    no-search-all,
-    no-wizard-in-models,
-    prohibited-method-override,
-    prefer-env-translation,
-    translation-format-interpolation,
-    translation-format-truncated,
-    translation-fstring-interpolation,
-    translation-not-lazy,
-    translation-too-few-args,
-    translation-too-many-args,
-    translation-unsupported-format,
-    no-write-in-compute
+    xml-attribute-translatable,
+    xml-deprecated-qweb-directive,
+    xml-deprecated-tree-attribute,
+    external-request-timeout
 
 [REPORTS]
 msg-template={path}:{line}: [{msg_id}({symbol}), {obj}] {msg}