-
-
Notifications
You must be signed in to change notification settings - Fork 196
[18.0][MIG] event_sale_reservation: Migration to 18.0 #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
[18.0][MIG] event_sale_reservation: Migration to 18.0 #436
Conversation
|
/ocabot migration event_sale_reservation |
ee9bcb8 to
e23e442
Compare
|
Hey @OCA/crm-sales-marketing-maintainers would be great if someone could have a look at this module. |
e23e442 to
fe38b34
Compare
FrancoMaxime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: code review
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This module extends the functionality of event_sale to support selling reservations of events that still don't exist and to allow you to schedule the creation of events based on how many reservations already exist. Includes integration workaround to avoid test conflicts with `event_sale_registration_multi_qty`. @Tecnativa TT27664 [UPD] Update event_sale_reservation.pot [UPD] README.rst
TT31321 [UPD] Update event_sale_reservation.pot [UPD] README.rst
Currently translated at 100.0% (32 of 32 strings) Translation: event-15.0/event-15.0-event_sale_reservation Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-event_sale_reservation/it/
Currently translated at 100.0% (32 of 32 strings) Translation: event-15.0/event-15.0-event_sale_reservation Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-event_sale_reservation/it/
Currently translated at 100.0% (32 of 32 strings) Translation: event-15.0/event-15.0-event_sale_reservation Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-event_sale_reservation/es/
Currently translated at 100.0% (32 of 32 strings) Translation: event-17.0/event-17.0-event_sale_reservation Translate-URL: https://translation.odoo-community.org/projects/event-17-0/event-17-0-event_sale_reservation/it/
fe38b34 to
f62cc7e
Compare
|
Hey @OCA/e-learning-maintainers would be great if someone could have a look at this module. |
etobella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical review
| _inherit = "product.template" | ||
|
|
||
| detailed_type = fields.Selection( | ||
| type = fields.Selection( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be better to use service_tracking?
A migration script might be needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve updated it as per your suggestion and used service_tracking. Thanks for your suggestion. Kindly please review.
No description provided.