Skip to content

[18.0][MIG] event_stage_cancelled: Migration to 18.0 #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BhaveshHeliconia wants to merge 9 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] event_stage_cancelled: Migration to 18.0 #437

BhaveshHeliconia wants to merge 9 commits into from

Conversation

@BhaveshHeliconia
Copy link
Contributor

@BhaveshHeliconia BhaveshHeliconia commented Feb 3, 2025

No description provided.

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-event_stage_cancelled branch from 544c554 to fd0472e Compare February 3, 2025 10:18
@pedrobaeza
Copy link
Member

pedrobaeza commented Feb 3, 2025

/ocabot migration event_stage_cancelled

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 3, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 3, 2025
Open
20 tasks
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-event_stage_cancelled branch from fd0472e to f01d14a Compare March 31, 2025 06:03
@BhaveshHeliconia
Copy link
Contributor Author

BhaveshHeliconia commented Apr 15, 2025

Hey @OCA/crm-sales-marketing-maintainers would be great if someone could have a look at this module.

@github-actions
Copy link

github-actions bot commented Aug 17, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 17, 2025
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-event_stage_cancelled branch from f01d14a to 7c4ce18 Compare August 18, 2025 04:39
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 24, 2025
FrancoMaxime
FrancoMaxime approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: code & functional review

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 15, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

mathisjacoby
mathisjacoby approved these changes Sep 23, 2025
View reviewed changes
Copy link

@mathisjacoby mathisjacoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review

chienandalu and others added 8 commits January 23, 2026 11:26
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-event_stage_cancelled branch from 7c4ce18 to 5a19004 Compare January 23, 2026 05:56
@BhaveshHeliconia
Copy link
Contributor Author

BhaveshHeliconia commented Jan 23, 2026

Hey @OCA/crm-sales-marketing-maintainers Please, can you merge this PR?

pedrobaeza
pedrobaeza reviewed Jan 23, 2026
View reviewed changes
event_stage_cancelled/tests/test_event_stage_cancelled.py Outdated
# with event_registration_cancel_reason
# First cancel the event/registrations
self.event.button_cancel()

Copy link
Member

@pedrobaeza pedrobaeza Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add empty lines inside the methods

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-event_stage_cancelled branch from 5a19004 to fc66df0 Compare January 23, 2026 06:17
pedrobaeza
pedrobaeza reviewed Jan 23, 2026
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the sense for the new tests. Are they auto-generated by AI?

@BhaveshHeliconia
Copy link
Contributor Author

BhaveshHeliconia commented Jan 23, 2026

I don't get the sense for the new tests. Are they auto-generated by AI?

This is an older PR, so I don’t remember the exact details offhand. I’ll review the whole module again and follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

+3 more reviewers

@FrancoMaxime FrancoMaxime FrancoMaxime approved these changes

@lmarion-source lmarion-source lmarion-source approved these changes

@mathisjacoby mathisjacoby mathisjacoby approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

9 participants

@BhaveshHeliconia @pedrobaeza @OCA-git-bot @FrancoMaxime @lmarion-source @mathisjacoby @chienandalu @victoralmau @mymage