[18.0][MIG]Add forbid_duplicates on event_type #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Sep 23, 2025
| # pylint: disable=W8120 | ||
| raise ValidationError( | ||
| self.env._("Duplicated partners found in event {0}: {1}.").format( | ||
| _("Duplicated partners found in event {0}: {1}.").format( |
| ] | ||
|
|
||
|
|
||
| class EventType(models.Model): |
| <field name="inherit_id" ref="event.view_event_form" /> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr="//field[@name='create_partner']" position="after"> | ||
| <xpath expr="//field[@name='badge_image']" position="after"> |
|
|
||
| @api.depends("event_type_id") | ||
| def _compute_forbid_duplicates(self): | ||
| """Update event configuration from its event type. Depends are set only |
Member
There was a problem hiding this comment.
This is a slight behavior change, as previously changing the type doesn't touch the field, but I think it can be acceptable.
| "installable": True, | ||
| "depends": ["partner_event"], | ||
| "data": ["views/event_event_view.xml"], | ||
| "depends": ["event", "partner_event"], |
Member
There was a problem hiding this comment.
No need to add the redundant dependency
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.