[19.0][MIG] hr_expense_tax_distribution: Migration to 19.0#351
Open
dnplkndll wants to merge 3 commits into
Open
[19.0][MIG] hr_expense_tax_distribution: Migration to 19.0#351dnplkndll wants to merge 3 commits into
dnplkndll wants to merge 3 commits into
Conversation
OCA-git-bot
added
series:19.0
mod:hr_expense_tax_distribution
dnplkndll
force-pushed
the
19.0-mig-hr_expense_tax_distribution
branch
from
4f05f21 to
35d1f0b
Compare
dnplkndll
changed the title
dnplkndll
force-pushed
the
19.0-mig-hr_expense_tax_distribution
branch
from
35d1f0b to
f18cfef
Compare
BhaveshHeliconia
approved these changes
Jun 19, 2026
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
Contributor
There was a problem hiding this comment.
Code review LGTM!
dnplkndll
force-pushed
the
19.0-mig-hr_expense_tax_distribution
branch
from
f18cfef to
2d2d725
Compare
dnplkndll
force-pushed
the
19.0-mig-hr_expense_tax_distribution
branch
from
2d2d725 to
52f4b93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
hr_expense_tax_distributionto 19.0.Non-mechanical adaptations worth flagging
_prepare_receipts_vals()and_prepare_payments_vals()onhr.expenseto bypass the completely removedhr.expense.sheetcore model._post_without_wizard).self.env._()pattern and wrapped long lines to pass the OCA ruff checks.