[18.0][IMP] hr_expense_petty_cash: fix journal items on petty cash with included tax and analytic#371
Merged
OCA-git-bot merged 1 commit intoJun 30, 2026
Conversation
OCA-git-bot
added
series:18.0
mod:hr_expense_petty_cash
1 task
…luded tax and analytic
Saran440
force-pushed
the
18.0-fix-petty_cash-journal-tax-analytic
branch
from
3cdc389 to
a913766
Compare
Member
Author
|
@BhaveshHeliconia Hi! Since you migrated this module to v18, would you be okay if we changed these lines? I think this is the standard approach. What do you think? |
BhaveshHeliconia
approved these changes
Jun 29, 2026
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
Contributor
There was a problem hiding this comment.
I tested this PR on an Odoo 18.0 database, and it works as expected. The refactored code uses Odoo 18's native journal entry engine to handle the tax split correctly.
Member
Author
|
/ocabot merge minor |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 0dc18ff. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixed 2 case
Before
After
