Skip to content

[18.0][ADD] sale_margin_pricelist_computation: New module#262

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
Tecnativa:18.0-add-sale_margin_pricelist_computation
Jun 17, 2026
Merged

[18.0][ADD] sale_margin_pricelist_computation: New module#262
OCA-git-bot merged 1 commit into
OCA:18.0from
Tecnativa:18.0-add-sale_margin_pricelist_computation

Conversation

@Andrii9090-tecnativa

@Andrii9090-tecnativa Andrii9090-tecnativa commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

This module extends product pricelists to support Python-based formulas
for computing product cost and product sale price for margin calculations.
image

@pedrobaeza can you review it?

@Tecnativa
TT62183

@OCA-git-bot OCA-git-bot added mod:sale_margin_pricelist_computation Module sale_margin_pricelist_computation series:18.0 labels Apr 28, 2026
@Andrii9090-tecnativa
Andrii9090-tecnativa marked this pull request as draft April 28, 2026 14:28
@Andrii9090-tecnativa
Andrii9090-tecnativa force-pushed the 18.0-add-sale_margin_pricelist_computation branch from 8a8b834 to a0b8090 Compare April 28, 2026 14:32
@Andrii9090-tecnativa
Andrii9090-tecnativa marked this pull request as ready for review April 28, 2026 14:36
@Andrii9090-tecnativa
Andrii9090-tecnativa force-pushed the 18.0-add-sale_margin_pricelist_computation branch from a0b8090 to a3a5da7 Compare April 30, 2026 14:10
@pedrobaeza pedrobaeza added this to the 18.0 milestone Apr 30, 2026
@Andrii9090-tecnativa
Andrii9090-tecnativa force-pushed the 18.0-add-sale_margin_pricelist_computation branch 2 times, most recently from 94cd816 to 5b28e09 Compare April 30, 2026 16:24
Comment thread sale_margin_pricelist_computation/models/product_pricelist_item.py Outdated
Comment thread sale_margin_pricelist_computation/models/product_pricelist_item.py Outdated
Comment thread sale_margin_pricelist_computation/models/sale_order_line.py Outdated
Comment thread sale_margin_pricelist_computation/models/sale_order_line.py Outdated
Comment thread sale_margin_pricelist_computation/models/sale_order_line.py Outdated
@pedrobaeza

Copy link
Copy Markdown
Member

Why removing the usage section?

@Andrii9090-tecnativa
Andrii9090-tecnativa force-pushed the 18.0-add-sale_margin_pricelist_computation branch from 076566a to 8910f2f Compare May 4, 2026 08:23
@Andrii9090-tecnativa
Andrii9090-tecnativa force-pushed the 18.0-add-sale_margin_pricelist_computation branch from 8910f2f to e634797 Compare June 4, 2026 07:13

@eduezerouali-tecnativa eduezerouali-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review + tested on runboat

Image Image

@eduezerouali-tecnativa

Copy link
Copy Markdown

ping @pedrobaeza

@pedrobaeza

Copy link
Copy Markdown
Member

We are facing the PyPi upload limitation, but let's try:

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-262-by-pedrobaeza-bump-nobump, awaiting test results.

@eduezerouali-tecnativa

Copy link
Copy Markdown

@pedrobaeza could we try to merge it again. Seems like it is been stuck

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-262-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit cc7bea6 into OCA:18.0 Jun 17, 2026
5 of 7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 0932e76. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
pedrobaeza deleted the 18.0-add-sale_margin_pricelist_computation branch June 17, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants