[14.0][FIX] pos_payment_terminal: read payment method ids fron config#1400
Closed
sbidoul wants to merge 1 commit into
Closed
[14.0][FIX] pos_payment_terminal: read payment method ids fron config#1400sbidoul wants to merge 1 commit into
sbidoul wants to merge 1 commit into
Conversation
Otherwise, it gets all payment methods even those that are not configured for the pos session, which leads to trying to use the proxy even if no payment mode that need it is configured
legalsylvain
approved these changes
Jun 19, 2025
legalsylvain
left a comment
legalsylvain
left a comment
Contributor
There was a problem hiding this comment.
Make sense.
Still draft ?
Member
Author
|
@xavier-bouquiaux is going to test it. |
sbidoul
changed the title
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
Contributor
|
Hi @sbidoul and @xavier-bouquiaux. Any new on that PR ? thanks ! |
github-actions
Bot
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, it gets all payment methods even those that are not configured for the pos session, which leads to trying to use the proxy even if no payment mode that needs it is configured.