[16.0][ADD] pos_order_exclude_attribute_combination#949
Conversation
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
| @@ -0,0 +1,22 @@ | |||
| .no_combination { | |||
There was a problem hiding this comment.
It'd be nice to move these css classes under a global one, to limit their domain.
A rule of thumb when you're developing a PoS module, is to define the css classes under the .pos class, which is added to the topmost parent element in the PoS UI.
.pos {
.no_combination {
...
}
...
}It's even better if you can specify even more.
In this case, you know the class will be used in the ProductConfiguratorPopup, whose top element has the product-configurator-popup class. So you could write it like this:
.pos {
.product-configurator-popup {
.no_combination {
...
}
...
}
}|
Unit tests would be nice, too ^^ |
No description provided.