Skip to content

[16.0][ADD] pos_order_exclude_attribute_combination#949

Open
sandipvyas-osi wants to merge 1 commit into
OCA:16.0from
ursais:16.0-add-pos_order_exclude_attribute_combination
Open

[16.0][ADD] pos_order_exclude_attribute_combination#949
sandipvyas-osi wants to merge 1 commit into
OCA:16.0from
ursais:16.0-add-pos_order_exclude_attribute_combination

Conversation

@sandipvyas-osi

Copy link
Copy Markdown

No description provided.

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 30, 2023
@github-actions github-actions Bot closed this Sep 3, 2023
@dreispt dreispt reopened this Nov 24, 2023
@dreispt dreispt added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Nov 24, 2023
@legalsylvain legalsylvain added this to the 16.0 milestone Feb 21, 2024
@@ -0,0 +1,22 @@
.no_combination {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to move these css classes under a global one, to limit their domain.

A rule of thumb when you're developing a PoS module, is to define the css classes under the .pos class, which is added to the topmost parent element in the PoS UI.

.pos {
    .no_combination {
        ...
    }
    ...
}

It's even better if you can specify even more.
In this case, you know the class will be used in the ProductConfiguratorPopup, whose top element has the product-configurator-popup class. So you could write it like this:

.pos {
    .product-configurator-popup {
        .no_combination {
            ...
        }
        ...
    }
}

@ivantodorovich

Copy link
Copy Markdown
Contributor

Unit tests would be nice, too ^^

@ivantodorovich ivantodorovich removed the no stale Use this label to prevent the automated stale action from closing this PR/Issue. label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants