Skip to content

[18.0][MIG] purchase_order_report_hide_tax: Migration to 18.0#95

Merged
OCA-git-bot merged 8 commits into
OCA:18.0from
qrtl:18.0-mig-purchase_order_report_hide_tax
Jan 31, 2026
Merged

[18.0][MIG] purchase_order_report_hide_tax: Migration to 18.0#95
OCA-git-bot merged 8 commits into
OCA:18.0from
qrtl:18.0-mig-purchase_order_report_hide_tax

Conversation

@AungKoKoLin1997

Copy link
Copy Markdown
Contributor

This PR includes

  • Migration using odoo-module-migrator
  • Add option in tax group to show the tax column in reports even if all purchase order lines have the same tax

@qrtl QT6349

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-mig-purchase_order_report_hide_tax branch from 35cde0a to c44cbe4 Compare January 27, 2026 09:16

@nobuQuartile nobuQuartile left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional review: LGTM

Functional review
Create two tax groups (e.g. Tax 10% and Tax 15%).
Create two purchase taxes and assign each one to its corresponding tax group.
Create Purchase Orders and print them, then check the result:
Case A:
All order lines use Tax 10%
→ The Taxes column should not be displayed in the printed report.
Case B:
Line 1 uses Tax 10%, line 2 uses Tax 15%
→ The Taxes column should be displayed.
Case C:
Enable “Show Tax Column in Purchase Report” on the Tax 10% tax group,
then create a PO where all lines use Tax 10%
→ The Taxes column should be displayed, even though all lines use the same tax group.

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the readme (CONFIGURE.md and others) and make the business purpose of the additional feature clear (for our use case, we want to hide the tax column for import transactions only).

Comment thread purchase_order_report_hide_tax/models/purchase_order.py Outdated
Comment thread purchase_order_report_hide_tax/models/account_tax_group.py Outdated
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-mig-purchase_order_report_hide_tax branch from c44cbe4 to aca728b Compare January 29, 2026 02:15
Comment thread purchase_order_report_hide_tax/readme/CONFIGURE.md Outdated
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-mig-purchase_order_report_hide_tax branch 2 times, most recently from a3a624e to a75e8a1 Compare January 29, 2026 04:30
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-mig-purchase_order_report_hide_tax branch from a75e8a1 to b81061e Compare January 29, 2026 04:41

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM.

@Andrii9090-tecnativa Andrii9090-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Code&funtional review (MIG and IMP) 👍

Image

IMP

Image

@Gelojr Gelojr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! @AungKoKoLin1997
The following tests have been performed and validated:

  • Test 1: Verified that when all purchase order lines share the same tax group, the tax column is correctly hidden in the report (OK).
  • Test 2: Verified that when purchase order lines include taxes from different tax groups, the tax column is correctly displayed in the report (OK).
  • Test 3: Verified that enabling “Show Tax Column in Purchase Report” on a tax group forces the tax column to be shown even when all lines share the same tax group (OK).
  • Test 4: Verified that section or note lines do not affect the tax column visibility logic and are correctly ignored in the calculation (OK).

PR approved.

@rafaelbn

Copy link
Copy Markdown
Member

/ocabot migration purchase_order_report_hide_tax

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 31, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 31, 2026
2 tasks
@rafaelbn

Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-95-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9150adc into OCA:18.0 Jan 31, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 44e5d62. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants