[19.0][MIG] purchase_order_report_hide_tax: Migration to 19.0#96
Conversation
…e showing tax column
OCA-git-bot
added
mod:purchase_order_report_hide_tax
fcvalgar
left a comment
fcvalgar
left a comment
There was a problem hiding this comment.
Great work on this migration @chienandalu . The module is simple, useful, and behaves as expected.
I have performed the following functional tests:
Test 1: OK - The “Show Tax Column in Purchase Report” field is available on the tax group form and list views.
Test 2: OK - A purchase order with all lines belonging to the same tax group hides the Taxes column in the printed report.
Test 3: OK - A purchase order with lines belonging to different tax groups shows the Taxes column in the printed report.
Test 4: OK - Enabling “Show Tax Column in Purchase Report” on the tax group forces the Taxes column to be displayed even when all lines share the same tax group.
Test 5: OK - Disabling “Show Tax Column in Purchase Report” restores the automatic behavior and hides the Taxes column for homogeneous tax groups.
Test 6: OK - A purchase order with a single line hides the Taxes column when the tax group does not force its display.
Test 7: OK - Section and note lines do not affect the decision to show or hide the Taxes column.
Test 8: OK - Hiding the Taxes column does not alter purchase order amounts, tax summary, or totals.
Test 9: OK - Confirming the purchase order does not change the report visibility logic.
Test 10: OK - A purchase order without lines does not generate technical errors when printing or previewing the report.
EmilioPascual
left a comment
EmilioPascual
left a comment
There was a problem hiding this comment.
Great job @chienandalu
Functional and code review
|
This PR has the |
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Just minor comments.
| @classmethod | ||
| def setUpClass(cls): | ||
| super().setUpClass() | ||
| cls.vendor = cls.env["res.partner"].create({"name": "Test Vendor"}) |
There was a problem hiding this comment.
| cls.vendor = cls.env["res.partner"].create({"name": "Test Vendor"}) |
BaseCommon already provides res.partner, so no need to create it again.
| { | ||
| "name": "Purchase order line hide tax in report", | ||
| "summary": "Hide taxes column when they don't add value", | ||
| "version": "19.0.1.0.1", |
There was a problem hiding this comment.
| "version": "19.0.1.0.1", | |
| "version": "19.0.1.0.0", |
|
/ocabot migration purchase_order_report_hide_tax |
|
@chienandalu please review comments |
chienandalu
force-pushed
the
19.0-mig-purchase_order_report_hide_tax
branch
from
1ead023 to
86acde4
Compare
|
Changes done |
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Code and functional review LGTM!
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 0a4fb95. Thanks a lot for contributing to OCA. ❤️ |
9 participants
cc @moduon MT-14451
please review @Gelojr @EmilioPascual