Conversation
|
|
||
| def has_working_hours(start_dt, end_dt): | ||
| """ | ||
| Returns `True` if there are any working days between `start_dt` and `end_dt`. |
There was a problem hiding this comment.
Should be imperative style https://stackoverflow.com/a/54868794
Same in previous docstring
victor-champonnois
left a comment
victor-champonnois
left a comment
There was a problem hiding this comment.
Hi, thank you for the work!
I did a small functional exploration on the interface.
- maybe a small doc on how to use the module would be nice
- I went on a project and clicked on "assign planning", there is a confirmation popup, and then nothing. What is this supposed to be doing ?
|
@antoniodavid |
Hi, could you explain the purpose of this feature? |
Thanks for the advice!!! |
|
@antoniodavid @FernandoRomera why the split? I don't get it. |
[16.0][ADD] hr_planning_resources [REF][16.0] hr_planning_resources: Refactoring app [16.0][ADD] hr_planning_resources: Add readme [16.0][ADD] hr_planning_resources: Add test-requirements Revert "[16.0][ADD] hr_planning_resources: Add readme" This reverts commit 4073ee9. [16.0][IMP] hr_planning_resources: Refactoring app
|
I also don't think it's necessary to split it since the scope of the module is clear |
I think you can edit and mention this is not really needed anymore. |
Fixed!!!! |
jelenapoblet
left a comment
jelenapoblet
left a comment
There was a problem hiding this comment.
On functional review, everything looks good, i was able to plan task, tickets and projects from the gantt view and viceversa.
| @api.model_create_multi | ||
| def create(self, vals_list): | ||
| if self.env.context.get("default_user_id", False): | ||
| vals_list[0]["user_id"] = [(4, self.env.context["default_user_id"])] |
There was a problem hiding this comment.
| vals_list[0]["user_id"] = [(4, self.env.context["default_user_id"])] | |
| vals_list[0]["user_id"] = self.env.context["default_user_id"] |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
8 participants
No description provided.