[FIX] sale_automatic_workflow: skip invoice creation when refund exists - fwp 4302#4444
Draft
rvalyi wants to merge 1 commit into
Draft
[FIX] sale_automatic_workflow: skip invoice creation when refund exists - fwp 4302#4444rvalyi wants to merge 1 commit into
rvalyi wants to merge 1 commit into
Conversation
OCA-git-bot
added
series:18.0
mod:sale_automatic_workflow
rvalyi
changed the title
rvalyi
marked this pull request as draft
July 2, 2026 15:19
When a posted invoice is reversed by a credit note, the automatic workflow incorrectly creates a new invoice because the credit note reduces qty_invoiced, making invoice_status = 'to invoice' again. Skip invoice creation when: - A posted out_invoice already exists, or - A posted out_refund linked to that invoice exists. Forward-port of fix and tests from PR OCA#4302 (OCA/sale-workflow, 16.0). Original author: muslim-foda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a posted invoice is reversed by a credit note, the automatic workflow incorrectly creates a new invoice because the credit note reduces qty_invoiced, making invoice_status = 'to invoice' again.
Skip invoice creation when:
Forward-port of fix from PR #4302 (OCA/sale-workflow, 16.0). Original author: muslim-foda