[18.0][ADD] sale_automatic_workflow_auto_assign: Allow workflows to be automatically assigned based on predicats#4445
Open
divad1196 wants to merge 2 commits into
Open
[18.0][ADD] sale_automatic_workflow_auto_assign: Allow workflows to be automatically assigned based on predicats#4445divad1196 wants to merge 2 commits into
divad1196 wants to merge 2 commits into
Conversation
OCA-git-bot
added
series:18.0
mod:sale_automatic_workflow_auto_assign
divad1196
force-pushed
the
workflow-auto-assign
branch
from
July 3, 2026 10:03
572ca36 to
b1fe452
Compare
divad1196
marked this pull request as ready for review
July 3, 2026 10:24
divad1196
changed the title
henrybackman
approved these changes
Jul 8, 2026
| @@ -0,0 +1,19 @@ | |||
| # Copyright 2024 Camptocamp SA | |||
Contributor
There was a problem hiding this comment.
Are the years correct?
Contributor
Author
There was a problem hiding this comment.
The module already existed on our side in a private repo.
I will have updated them
…matically assigned based on predicats
divad1196
force-pushed
the
workflow-auto-assign
branch
from
July 9, 2026 06:48
85a5640 to
bf247e2
Compare
santostelmo
approved these changes
Jul 20, 2026
santostelmo
left a comment
santostelmo
left a comment
Contributor
There was a problem hiding this comment.
PR LG.
some improvement (optional):
Add a test that covers multiple matching workflows and proves the lowest priority value wins. The README and implementation both state that matching workflows are ordered by priority, but the current tests only cover a single workflow match / no match cases. Since priority is a core part of the feature contract, this should be locked down with a regression test in sale_automatic_workflow_auto_assign/tests/test_sale_workflow.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on PR: #4419
(Because of the global setting)
It adds a new module that allows to auto-assign workflows on sales based on a domain matching