[17.0] [IMP] auto_backup: add hostkey support in sftp connection #3462
+269
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As said on OCA#3139 there is no exist_ok parameter in remote.makedirs() function.
rrebollo
force-pushed
the
17.0-imp-auto_backup-hostkey-support
branch
from
47aea03 to
d080270
Compare
Add a new "Host Public Key" field to verify the identity of the remote SFTP server. - When filled: strict host key verification (protects against man-in-the-middle attacks) - When empty: host key checking disabled (old behavior preserved, no known_hosts warnings) - "Test SFTP Connection" button now also validates the provided key - Eliminates the UserWarning about missing ~/.ssh/known_hosts - All existing tests pass - New comprehensive test added for valid/invalid/empty key cases - Documentation updated in readme/USAGE.md Based on the original (never merged) PR OCA#2195 from 14.0, now correctly implemented and fully tested for 17.0.
rrebollo
force-pushed
the
17.0-imp-auto_backup-hostkey-support
branch
from
d080270 to
a66b508
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new "Host Public Key" field to verify the identity of the remote SFTP server.
Based on the original (never merged) PR #2195 from 14.0, now correctly implemented and fully tested for 17.0.
The first 2 commits are from #3461. Working on this discovered the missing commits on branch 17.0.
@BinhexTeam