Skip to content

[19.0][IMP] base_tier_validation: rewrite tier_review_widget collapse with native <details> #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bosd wants to merge 1 commit into
base: 19.0
Choose a base branch
from
Open

[19.0][IMP] base_tier_validation: rewrite tier_review_widget collapse with native <details> #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 1 addition & 24 deletions base_tier_validation/static/src/components/tier_review_widget/tier_review_widget.esm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,11 @@
import {Component, useState} from "@odoo/owl";
import {Component} from "@odoo/owl";
import {registry} from "@web/core/registry";
import {useService} from "@web/core/utils/hooks";

export class ReviewsTable extends Component {
setup() {
super.setup();
this.orm = useService("orm");
this.state = useState({
collapse: false,
});
}

_getReviewData() {
const records = this.props.record.data.review_ids.records;
return records.map((record) => record.data);
}

onToggleCollapse(ev) {
const panelHeading = ev.currentTarget.closest(".panel-heading");
const collapseDiv = panelHeading.nextElementSibling.matches("div#collapse1")
? panelHeading.nextElementSibling
: null;
if (!collapseDiv) return;
if (this.state.collapse) {
collapseDiv.style.display = "none";
} else {
collapseDiv.style.display = "block";
}
this.state.collapse = !this.state.collapse;
}
}

ReviewsTable.template = "base_tier_validation.Collapse";
Expand Down
44 changes: 25 additions & 19 deletions base_tier_validation/static/src/components/tier_review_widget/tier_review_widget.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,39 +3,45 @@ ul.o_review {
max-width: 800px;
}

.panel-group {
.o_tier_review_widget {
min-height: auto !important;
margin-top: -6px !important;
padding: 16px 16px 8px 16px !important;
}

.panel-heading {
background-color: initial !important;
}

.panel {
border: 0 !important;
}

.panel-body {
.o_tier_review_body {
overflow-y: hidden;
overflow-x: auto;
}

.panel-title > a,
.panel-title > a:active {
/* Style the native <summary> as a section heading. The browser
handles open/close state itself; we only re-skin the disclosure
triangle to match Odoo's FontAwesome caret look. */
.o_tier_review_details > summary {
cursor: pointer;
list-style: none;
font-weight: bold;
padding: 8px 0;
display: block;
}

.panel-heading a:before {
.o_tier_review_details > summary::-webkit-details-marker {
display: none;
}

.o_tier_review_details > summary::before {
font-family: FontAwesome;
content: "\f0d7";
float: right;
transition: all 0.5s;
margin-right: 8px;
display: inline-block;
transition: transform 0.3s;
}

.o_tier_review_details:not([open]) > summary::before {
transform: rotate(-90deg);
}

.panel-heading.active a:before {
-webkit-transform: rotate(180deg);
-moz-transform: rotate(180deg);
transform: rotate(180deg);
.o_tier_review_widget .o_tier_review_seq {
width: 2rem;
white-space: nowrap;
}
197 changes: 93 additions & 104 deletions base_tier_validation/static/src/components/tier_review_widget/tier_review_widget.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,114 +1,103 @@
<?xml version="1.0" encoding="UTF-8" ?>
<templates>
<t t-name="base_tier_validation.Collapse">
<div class="o_form_sheet panel-group">
<div class="panel panel-default">
<div class="panel-heading">
<h4 class="panel-title">
<a
class="o_info_btn"
data-toggle="state.collapse"
href="#"
data-target="#collapse1"
t-on-click="onToggleCollapse"
>
Reviews
</a>
</h4>
</div>
<div id="collapse1" class="panel-collapse collapse active">
<div class="panel-body o_review">
<table class="oe_mt32 table table-condensed">
<thead>
<tr>
<th
name="th_sequence"
class="text-center"
>Sequence</th>
<th
name="th_requested_by"
class="text-start"
>Requested by</th>
<th name="th_name" class="text-end">Description</th>
<th
name="th_display_status"
class="text-end"
>Status</th>
<th name="th_todo_by" class="text-end">Todo by</th>
<th name="th_done_by" class="text-end">Done by</th>
<th
name="th_reviewed_date"
class="text-end"
>Validation Date</th>
<th name="th_comment" class="text-end">Comment</th>
</tr>
</thead>
<tbody class="sale_tbody">
<div class="o_form_sheet o_tier_review_widget">
<details class="o_tier_review_details" open="open">
<summary class="o_tier_review_summary">Reviews</summary>
<div class="o_tier_review_body o_review">
<table class="mt-4 table table-sm">
<thead>
<tr>
<th
name="th_sequence"
class="text-center o_tier_review_seq"
>#</th>
<th
name="th_requested_by"
class="text-start"
>Requested by</th>
<th name="th_name" class="text-start">Description</th>
<th
name="th_display_status"
class="text-start"
>Status</th>
<th name="th_todo_by" class="text-start">Todo by</th>
<th name="th_done_by" class="text-start">Done by</th>
<th
name="th_reviewed_date"
class="text-start"
>Validation Date</th>
<th name="th_comment" class="text-start">Comment</th>
</tr>
</thead>
<tbody class="sale_tbody">
<t
t-foreach="_getReviewData()"
t-as="review"
t-key="review.id"
>
<t
t-if="review.status == 'waiting' or review.status == 'cancel'"
t-set="status_class"
t-value="'text-muted'"
/>
<t
t-foreach="_getReviewData()"
t-as="review"
t-key="review.id"
>
<t
t-if="review.status == 'waiting' or review.status == 'cancel'"
t-set="status_class"
t-value="'text-muted'"
/>
<t
t-if="review.status == 'pending'"
t-set="status_class"
t-value=""
/>
<t
t-if="review.status == 'approved'"
t-set="status_class"
t-value="'alert alert-success'"
/>
<t
t-if="review.status == 'rejected'"
t-set="status_class"
t-value="'alert alert-danger'"
/>
<tr t-att-class="status_class">
<td name="td_sequence" class="text-center">
<span t-out="review.sequence" />
</td>
<td name="td_requested_by" class="text-start">
t-if="review.status == 'pending'"
t-set="status_class"
t-value="''"
/>
<t
t-if="review.status == 'approved'"
t-set="status_class"
t-value="'table-success'"
/>
<t
t-if="review.status == 'rejected'"
t-set="status_class"
t-value="'table-danger'"
/>
<tr t-att-class="status_class">
<td
name="td_sequence"
class="text-center o_tier_review_seq"
>
<span t-out="review.sequence" />
</td>
<td name="td_requested_by" class="text-start">
<span
t-out="review.requested_by.display_name"
/>
</td>
<td name="td_name" class="text-start">
<span t-out="review.name" />
</td>
<td name="td_display_status" class="text-start">
<span t-out="review.display_status" />
</td>
<td name="td_todo_by" class="text-start">
<span t-out="review.todo_by" />
</td>
<td name="td_done_by" class="text-start">
<span t-out="review.done_by.display_name" />
</td>
<td name="td_reviewed_date" class="text-start">
<t t-if="review.reviewed_formated_date">
<span
t-out="review.requested_by.display_name"
t-out="review.reviewed_formated_date"
/>
</td>
<td name="td_name" class="text-end">
<span t-out="review.name" />
</td>
<td name="td_display_status" class="text-end">
<span t-out="review.display_status" />
</td>
<td name="td_todo_by" class="text-end">
<span t-out="review.todo_by" />
</td>
<td name="td_done_by" class="text-end">
<span t-out="review.done_by.display_name" />
</td>
<td name="td_reviewed_date" class="text-end">
<t t-if="review.reviewed_formated_date">
<span
t-out="review.reviewed_formated_date"
/>
</t>
</td>
<td name="td_comment" class="text-start">
<t t-if="review.comment">
<span t-out="review.comment" />
</t>
</td>
</tr>
</t>
</tbody>
</table>
</div>
</t>
</td>
<td name="td_comment" class="text-start">
<t t-if="review.comment">
<span t-out="review.comment" />
</t>
</td>
</tr>
</t>
</tbody>
</table>
</div>
</div>
</details>
</div>
</t>
</templates>
Loading