Skip to content

make repository builder more extensible #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pwinckles merged 2 commits into from
Dec 18, 2024
Merged

make repository builder more extensible #124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56fc575
make repsitory builder more extensible
Mewel Dec 13, 2024
6a1b2c4
make buildInternal() private again
Mewel Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions ocfl-java-core/src/main/java/io/ocfl/core/OcflRepositoryBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,21 +69,21 @@
*/
public class OcflRepositoryBuilder {

private OcflStorage storage;
private OcflConfig config;
private OcflExtensionConfig defaultLayoutConfig;
private Path workDir;
private boolean verifyStaging;
private Duration fileLockTimeoutDuration;

private ObjectLock objectLock;
private Cache<String, Inventory> inventoryCache;
private InventoryMapper inventoryMapper;
private LogicalPathMapper logicalPathMapper;
private ContentPathConstraintProcessor contentPathConstraintProcessor;
private ObjectDetailsDatabase objectDetailsDb;
private UnsupportedExtensionBehavior unsupportedBehavior;
private Set<String> ignoreUnsupportedExtensions;
protected OcflStorage storage;
protected OcflConfig config;
protected OcflExtensionConfig defaultLayoutConfig;
protected Path workDir;
protected boolean verifyStaging;
protected Duration fileLockTimeoutDuration;

protected ObjectLock objectLock;
protected Cache<String, Inventory> inventoryCache;
protected InventoryMapper inventoryMapper;
protected LogicalPathMapper logicalPathMapper;
protected ContentPathConstraintProcessor contentPathConstraintProcessor;
protected ObjectDetailsDatabase objectDetailsDb;
protected UnsupportedExtensionBehavior unsupportedBehavior;
protected Set<String> ignoreUnsupportedExtensions;

/**
* Constructs a local file system based OCFL repository sensible defaults that can be overridden prior to calling
Expand Down Expand Up @@ -454,14 +454,14 @@ private <T extends OcflRepository> T buildInternal(Class<T> clazz) {
fileLockTimeoutDuration));
}

private OcflStorage cache(OcflStorage storage) {
protected OcflStorage cache(OcflStorage storage) {
if (inventoryCache != null) {
return new CachingOcflStorage(inventoryCache, storage);
}
return storage;
}

private OcflStorage db(OcflStorage storage) {
protected OcflStorage db(OcflStorage storage) {
if (objectDetailsDb != null) {
return new ObjectDetailsDbOcflStorage(objectDetailsDb, storage);
}
Expand Down
Loading