Skip to content

PBS: honour non-sRGB colour targets in the pass hash #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steffen-roemer wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PBS: honour non-sRGB colour targets in the pass hash #584

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0e5dba
PBS: honour non-sRGB colour targets in the pass hash
steffen-roemer Jul 17, 2026
f0e8cff
Satisfy clang-format
steffen-roemer Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion Components/Hlms/Pbs/src/OgreHlmsPbs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1848,7 +1848,21 @@ namespace Ogre

const RenderSystemCapabilities *capabilities = mRenderSystem->getCapabilities();
setProperty( kNoTid, PbsProperty::HwGammaRead, capabilities->hasCapability( RSC_HW_GAMMA ) );
setProperty( kNoTid, PbsProperty::HwGammaWrite, 1 );
{
// Honour non-sRGB colour targets: without hardware gamma on write the
// shader must gamma-encode the linear lighting result itself (the
// !hw_gamma_write template path), otherwise PBS output lands raw in a
// UNORM target and displays crushed/dark.
bool hwGammaWrite = true;
const RenderPassDescriptor *colourPassDesc = mRenderSystem->getCurrentPassDescriptor();
if( colourPassDesc && colourPassDesc->getNumColourEntries() > 0u &&
colourPassDesc->mColour[0].texture )
{
hwGammaWrite =
PixelFormatGpuUtils::isSRgb( colourPassDesc->mColour[0].texture->getPixelFormat() );
}
setProperty( kNoTid, PbsProperty::HwGammaWrite, hwGammaWrite ? 1 : 0 );
}
retVal.setProperties = mT[kNoTid].setProperties;

CamerasInProgress cameras = sceneManager->getCamerasInProgress();
Expand Down
Loading