Fix hardcode root cert store provider to None - #165
Open
SantanM wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the runtime’s TLS root certificate handling so that (when DENO_TLS_CA_STORE is not set) the system trust store is used by default, and the configured root cert store provider is passed into deno_fetch so fetch requests use it.
Changes:
- Switch the default
DENO_TLS_CA_STOREfallback from"mozilla"to"system". - Provide
deno_fetchwith an explicitroot_cert_store_providerinstead of leaving it asNone.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/deno_facade/cert_provider.rs | Changes default CA store selection to prefer the system trust store. |
| crates/base/src/runtime/mod.rs | Wires the computed root cert store provider into deno_fetch options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1029
to
1032
| deno_fetch::Options { | ||
| user_agent: "supabase-edge-runtime".to_string(), | ||
| root_cert_store_provider: None, | ||
| root_cert_store_provider: Some(_root_cert_store_provider), | ||
| unsafely_ignore_certificate_errors: None, |
SantanM
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.