Skip to content

Adding a region scoping page for region rollouts #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ITblacksheep merged 3 commits into from
Oct 12, 2026
Merged

Adding a region scoping page for region rollouts #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
779c139
Fixing requested issues
ITblacksheep Oct 12, 2026
85ca2a2
Fixing test to match prod
ITblacksheep Oct 12, 2026
25063f8
readding in correct test
ITblacksheep Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/deploy.yml
View file
Open in desktop
Comment thread
ITblacksheep marked this conversation as resolved.
Comment thread
ITblacksheep marked this conversation as resolved.
Comment thread
ITblacksheep marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,8 @@ jobs:
CHROMIUM_REQUIRE=1 BASE_URL=http://localhost:13581 node tests/e2e/test-home-coverage-e2e.js 2>&1 | tee -a e2e-output.txt
echo "=== E2E SUITE: test-path-inspector-coverage-e2e.js ==="
CHROMIUM_REQUIRE=1 BASE_URL=http://localhost:13581 node tests/e2e/test-path-inspector-coverage-e2e.js 2>&1 | tee -a e2e-output.txt
echo "=== E2E SUITE: test-region-def-e2e.js ==="
CHROMIUM_REQUIRE=1 BASE_URL=http://localhost:13581 node tests/e2e/test-region-def-e2e.js 2>&1 | tee -a e2e-output.txt
echo "=== E2E SUITE: test-issue-1206-resize-observer-leak-e2e.js ==="
CHROMIUM_REQUIRE=1 BASE_URL=http://localhost:13581 node tests/e2e/test-issue-1206-resize-observer-leak-e2e.js 2>&1 | tee -a e2e-output.txt
echo "=== E2E SUITE: test-nav-drawer-1064-e2e.js ==="
Expand Down
6 changes: 5 additions & 1 deletion .gitignore
View file
Open in desktop
Comment thread
ITblacksheep marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,8 @@ docs/superpowers/
deploy-live.sh
deploy-staging.sh

.DS_Store
.DS_Store

#geojson files. Only allow the example ones.
public/region-layers/*
!public/region-layers/*.example
288 changes: 288 additions & 0 deletions docs/region-def.md
View file
Open in desktop
Comment thread
ITblacksheep marked this conversation as resolved.
Comment thread
ITblacksheep marked this conversation as resolved.
Comment thread
ITblacksheep marked this conversation as resolved.

Large diffs are not rendered by default.

10 changes: 7 additions & 3 deletions public/app.js
View file
Open in desktop
Comment thread
ITblacksheep marked this conversation as resolved.
Comment thread
ITblacksheep marked this conversation as resolved.
Comment thread
ITblacksheep marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -1106,7 +1106,8 @@ registerPage('tools-landing', {
'<div class="tools-menu">' +
'<a href="#/tools/path-inspector" class="tools-card"><h3><svg class="ph-icon" aria-hidden="true"><use href="/icons/phosphor-sprite.svg#ph-magnifying-glass"/></svg> Path Inspector</h3><p>Resolve prefix paths to candidate full-pubkey routes with confidence scoring.</p></a>' +
'<a href="#/tools/trace/" class="tools-card"><h3><svg class="ph-icon" aria-hidden="true"><use href="/icons/phosphor-sprite.svg#ph-broadcast"/></svg> Trace Viewer</h3><p>View detailed packet traces by hash.</p></a>' +
'</div>' +
'<a href="#/tools/region-def" class="tools-card"><h3><svg class="ph-icon" aria-hidden="true"><use href="/icons/phosphor-sprite.svg#ph-map-pin"/></svg> Region Def</h3><p>Look up an address and get the repeater <code>region def</code> commands for its regions.</p></a>' +
'</div>' +
'</div>';
},
destroy: function () {}
Expand Down Expand Up @@ -1182,14 +1183,17 @@ function navigate() {
basePage = 'observer-detail';
}

// Tools sub-routing (issue #944): tools/trace/<hash>, tools/path-inspector
// Tools sub-routing (issue #944): tools/trace/<hash>, tools/path-inspector, tools/region-def (issue #187)
if (basePage === 'tools') {
if (routeParam && routeParam.startsWith('trace/')) {
basePage = 'traces';
routeParam = routeParam.substring(6); // strip "trace/"
} else if (routeParam === 'path-inspector' || (routeParam && routeParam.startsWith('path-inspector'))) {
basePage = 'path-inspector';
routeParam = null;
} else if (routeParam === 'region-def') {
basePage = 'region-def';
routeParam = null;
} else if (!routeParam) {
// Default tools landing shows menu with both entries.
basePage = 'tools-landing';
Expand All @@ -1202,7 +1206,7 @@ function navigate() {

// Update nav active state
document.querySelectorAll('.nav-link[data-route]').forEach(el => {
el.classList.toggle('active', el.dataset.route === basePage || (el.dataset.route === 'tools' && (basePage === 'traces' || basePage === 'path-inspector' || basePage === 'tools-landing')));
el.classList.toggle('active', el.dataset.route === basePage || (el.dataset.route === 'tools' && (basePage === 'traces' || basePage === 'path-inspector' || basePage === 'region-def' || basePage === 'tools-landing')));
});
// Update "More" button to show active state if a low-priority page is selected
var moreBtn = document.getElementById('navMoreBtn');
Expand Down
3 changes: 3 additions & 0 deletions public/index.html
View file
Open in desktop
Comment thread
ITblacksheep marked this conversation as resolved.
Comment thread
ITblacksheep marked this conversation as resolved.
Comment thread
ITblacksheep marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
<link rel="stylesheet" href="node-reach-coverage.css?v=__BUST__">
<link rel="stylesheet" href="bottom-nav.css?v=__BUST__">
<link rel="stylesheet" href="nav-drawer.css?v=__BUST__">
<link rel="stylesheet" href="region-def.css?v=__BUST__">
<link rel="stylesheet" href="https://unpkg.com/leaflet@1.9.4/dist/leaflet.css"
integrity="sha256-p4NxAoJBhIIN+hmNHrzRCf9tD/miZyoHS5obTRR9BMY="
crossorigin="anonymous">
Expand Down Expand Up @@ -215,6 +216,8 @@
<script src="nodes.js?v=__BUST__" onerror="console.error('Failed to load:', this.src)"></script>
<script src="traces.js?v=__BUST__" onerror="console.error('Failed to load:', this.src)"></script>
<script src="path-inspector.js?v=__BUST__" onerror="console.error('Failed to load:', this.src)"></script>
<script src="region-def-core.js?v=__BUST__" onerror="console.error('Failed to load:', this.src)"></script>
<script src="region-def.js?v=__BUST__" onerror="console.error('Failed to load:', this.src)"></script>
<script src="analytics.js?v=__BUST__" onerror="console.error('Failed to load:', this.src)"></script>
<script src="audio.js?v=__BUST__" onerror="console.error('Failed to load:', this.src)"></script>
<script src="audio-v1-constellation.js?v=__BUST__" onerror="console.error('Failed to load:', this.src)"></script>
Expand Down
Loading
Loading