Skip to content

[codex] Validate managed path dependencies#45

Merged
jmcte merged 1 commit into
mainfrom
codex/validate-managed-path-dependencies
Jun 10, 2026
Merged

[codex] Validate managed path dependencies#45
jmcte merged 1 commit into
mainfrom
codex/validate-managed-path-dependencies

Conversation

@jmcte

@jmcte jmcte commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Reject repo.managedPaths selections that include generated guidance while excluding companion files those templates reference.
  • Add a CloudCurator-shaped smoke regression for restricted managed paths.
  • Update selected-file adoption coverage so AGENTS.md is only adopted with the required hook, PR template, and onboarding companions.

Governing Issue

No governing issue is linked; this is cleanup from live bootstrap application failures found while reconciling downstream repos.

Validation

  • Relevant local checks passed: npm test (10 files, 58 tests)
  • Required PR checks are expected to satisfy CI Gate
  • Skipped checks are explained below

No checks were intentionally skipped.

Bootstrap Governance

  • Changes are scoped to the linked issue
  • Contributor or PR guidance changes are reflected in CONTRIBUTING.md, .github/PULL_REQUEST_TEMPLATE.md, and docs/bootstrap/onboarding.md when applicable
  • Auto-merge is enabled, or GitHub plan-limit evidence is recorded and the fallback merge-readiness policy applies
  • No real secrets, runtime auth, or machine-local env files are committed

No governing issue is linked; this change tightens bootstrap validation after downstream generated guidance exposed missing managed-path dependency checks. Auto-merge is not enabled from this local session; use the fallback merge-readiness policy after required checks and review pass.

Merge Automation

  • Auto-merge is enabled, or the reason it is unavailable or unsafe is noted below

Auto-merge was not enabled because GitHub CLI authentication is unstable in this session. Fallback merge-readiness applies once review and required checks are green.

Notes

  • The validation is intentionally fail-fast before any files are written to a target repo.
  • This should prevent partial bootstrap adoption that copies guidance without the referenced enforcement and onboarding files.

Reject restricted repo.managedPaths selections that include generated guidance while excluding the companion hook, PR template, or onboarding document those files reference.

Add a CloudCurator-shaped smoke regression and update the selected-file adoption test to include required companions.
@jmcte jmcte marked this pull request as ready for review June 10, 2026 16:40
@jmcte jmcte requested a review from pheidon as a code owner June 10, 2026 16:40
@jmcte jmcte enabled auto-merge (squash) June 10, 2026 16:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 54e5e5c424

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/render.ts

@pheidon pheidon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The managed-path dependency guard is targeted, the error is clear, and the smoke test covers the new constraint.

@jmcte jmcte merged commit bc076ca into main Jun 10, 2026
17 checks passed
@jmcte jmcte deleted the codex/validate-managed-path-dependencies branch June 10, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants