[codex] Validate managed path dependencies#45
Merged
Conversation
Reject restricted repo.managedPaths selections that include generated guidance while excluding the companion hook, PR template, or onboarding document those files reference. Add a CloudCurator-shaped smoke regression and update the selected-file adoption test to include required companions.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54e5e5c424
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pheidon
approved these changes
Jun 10, 2026
pheidon
left a comment
Contributor
There was a problem hiding this comment.
Looks good. The managed-path dependency guard is targeted, the error is clear, and the smoke test covers the new constraint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repo.managedPathsselections that include generated guidance while excluding companion files those templates reference.AGENTS.mdis only adopted with the required hook, PR template, and onboarding companions.Governing Issue
No governing issue is linked; this is cleanup from live bootstrap application failures found while reconciling downstream repos.
Validation
npm test(10 files, 58 tests)CI GateNo checks were intentionally skipped.
Bootstrap Governance
CONTRIBUTING.md,.github/PULL_REQUEST_TEMPLATE.md, anddocs/bootstrap/onboarding.mdwhen applicableNo governing issue is linked; this change tightens bootstrap validation after downstream generated guidance exposed missing managed-path dependency checks. Auto-merge is not enabled from this local session; use the fallback merge-readiness policy after required checks and review pass.
Merge Automation
Auto-merge was not enabled because GitHub CLI authentication is unstable in this session. Fallback merge-readiness applies once review and required checks are green.
Notes