Skip to content

[codex] Fix Safari CloudTabs schema query#75

Merged
jmcte merged 1 commit into
mainfrom
codex/fix-safari-cloud-tabs-schema
Jun 11, 2026
Merged

[codex] Fix Safari CloudTabs schema query#75
jmcte merged 1 commit into
mainfrom
codex/fix-safari-cloud-tabs-schema

Conversation

@pheidon

@pheidon pheidon commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • route Safari CloudTabs listing through the live cloud_tabs + cloud_tab_devices schema
  • expose explicit CloudTabs fields for device name, title, URL, sync timestamp, position, pinned, reader, and scene data
  • update the broad inventory fixture to match the live Safari CloudTabs database shape

Root Cause

The prior implementation used the generic metadata-table query path for safariCloudTabsList, but the live Safari CloudTabs store does not contain a safari_cloud_tabs table. The current local store uses cloud_tabs joined to cloud_tab_devices.

Validation

  • Hermes: swift test passed, 57 tests
  • Hermes: swift build -c release passed
  • Hermes: reinstalled binary to /Users/johnteneyckjr./.local/bin/icloud-cli
  • Hermes: icloud-cli safari cloud-tabs probe --format json succeeded
  • Hermes: icloud-cli safari cloud-tabs list --confirm-sensitive --format json --limit 5 succeeded and returned 5 rows
  • Pheidon: local swift test not run because Swift is not installed on this host

@jmcte jmcte marked this pull request as ready for review June 11, 2026 20:23
@jmcte jmcte self-requested a review as a code owner June 11, 2026 20:23
@jmcte jmcte enabled auto-merge (squash) June 11, 2026 20:24
@jmcte jmcte merged commit 32ce14a into main Jun 11, 2026
2 checks passed
@jmcte jmcte deleted the codex/fix-safari-cloud-tabs-schema branch June 11, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants