[codex] Fix Safari CloudTabs schema query#75
Merged
Conversation
jmcte
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloud_tabs+cloud_tab_devicesschemaRoot Cause
The prior implementation used the generic metadata-table query path for
safariCloudTabsList, but the live Safari CloudTabs store does not contain asafari_cloud_tabstable. The current local store usescloud_tabsjoined tocloud_tab_devices.Validation
swift testpassed, 57 testsswift build -c releasepassed/Users/johnteneyckjr./.local/bin/icloud-cliicloud-cli safari cloud-tabs probe --format jsonsucceededicloud-cli safari cloud-tabs list --confirm-sensitive --format json --limit 5succeeded and returned 5 rowsswift testnot run because Swift is not installed on this host