[codex] Improve inventory schema handling#76
Merged
Conversation
d026661 to
93c3b67
Compare
3271022 to
8fc5a09
Compare
jmcte
approved these changes
Jun 11, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fc5a09790
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloud_tabs/cloud_tab_devicesschemachat.dbschema support for conversations and recent-message metadataAddressBook/Sources/*/AddressBook-v22.abcddbWhy
The privacy-safe Hermes sweep showed several broad inventory commands failing against real Apple stores because the CLI was querying synthetic placeholder table names or old default paths. This patch makes schema drift explicit and actionable, keeps CloudTabs on the live schema already verified on Hermes, starts replacing synthetic assumptions with real Apple schema adapters, and resolves the modern Contacts database location.
Validation
git diff --check: passed locally on Pheidon93c3b6785b70618fc5a09swiftis not installed hereRemaining Follow-Up
messages conversations, or add a CLI--limitoption for that command before re-running on a full live store