Support Apple Contacts record schema#78
Merged
Merged
Conversation
jmcte
previously approved these changes
Jun 11, 2026
# Conflicts: # Sources/ICloudCLICore/LocalInventories.swift # Tests/ICloudCLICoreTests/LocalInventoriesTests.swift
jmcte
approved these changes
Jun 12, 2026
jmcte
approved these changes
Jun 12, 2026
Contributor
Author
|
Reviewed this pass; no blocking issues found. The Apple Contacts schema fallback and record mapping look coherent, including the field extraction, notes handling/redaction behavior, and fixture coverage for the new contacts shape. I do not see a code defect or test gap that should block this PR. Merge call: ready to merge from my review. |
athena-omt
approved these changes
Jun 12, 2026
athena-omt
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the contact schema change. I did not find blocking issues. The schema fallback, Contacts field mapping, note redaction behavior, and fixture coverage look coherent to me. This is ready to merge from my pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Privacy