Skip to content

Limit message conversation output#79

Merged
jmcte merged 3 commits into
mainfrom
codex/messages-conversation-limit
Jun 12, 2026
Merged

Limit message conversation output#79
jmcte merged 3 commits into
mainfrom
codex/messages-conversation-limit

Conversation

@pheidon

@pheidon pheidon commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • wire the existing MessagesOptions limit through messages conversations
  • add LIMIT clauses for synthetic and Apple chat.db conversation readers
  • advertise --limit in command help
  • add parser and reader regression coverage

Validation

  • git diff --check
  • GitHub PR Fast CI / CI Gate: passed on f1279eb
  • Hermes/macOS: swift test --disable-sandbox passed
  • Hermes/macOS: swift build -c release passed

Privacy

  • this makes privacy-safe live validation easier by bounding messages conversations output
  • no live Messages smoke test was run during validation, so no chat identifiers, names, or message values were queried or printed

@pheidon pheidon marked this pull request as ready for review June 11, 2026 22:09
@pheidon pheidon requested a review from jmcte as a code owner June 11, 2026 22:09
jmcte
jmcte previously approved these changes Jun 11, 2026
@jmcte jmcte enabled auto-merge (squash) June 11, 2026 23:01
# Conflicts:
#	Tests/ICloudCLICoreTests/LocalInventoriesTests.swift
jmcte
jmcte previously approved these changes Jun 12, 2026
@pheidon

pheidon commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Reviewed this pass; no code defect found.

The new --limit wiring for messages conversations is carried through to both synthetic fixtures and the Apple chat.db reader, and the bounded SQL LIMIT behavior looks consistent with the command surface. I do not see a functional blocker in the implementation.

Merge call: functionally looks good; merge should still respect the repository approval/check requirements.

@pheidon pheidon added review:athena Athena review governance requested. status:needs-review PR is ready for Athena review. labels Jun 12, 2026

@athena-omt athena-omt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the conversation limit change. I did not find a code defect: --limit is wired into , and the bounded LIMIT clauses cover both the synthetic reader and Apple path. Functionally looks good; merge should wait for the required approving review if branch protections require it.

athena-omt
athena-omt previously approved these changes Jun 12, 2026

@athena-omt athena-omt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the conversation limit change. I did not find a code defect: --limit is wired into messages conversations, and the bounded LIMIT clauses cover both the synthetic reader and Apple chat.db path. Functionally looks good; merge should wait for the required approving review if branch protections require it.

@jmcte jmcte dismissed stale reviews from athena-omt and themself via 55e55dc June 12, 2026 16:34

@athena-omt athena-omt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the conversation limit change. I did not find a code defect: --limit is wired into messages conversations, and the bounded LIMIT clauses cover both the synthetic reader and Apple chat.db path. Functionally looks good; merge should wait for the required approving review if branch protections require it.

@jmcte jmcte merged commit 9927013 into main Jun 12, 2026
1 check passed
@jmcte jmcte deleted the codex/messages-conversation-limit branch June 12, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:athena Athena review governance requested. status:needs-review PR is ready for Athena review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants