Fix Go-era CI fast checks#78
Merged
Merged
Conversation
1800651 to
59ce4c2
Compare
Replace stale Bats and deleted shell test references with the current Go validation surface: shellcheck, module verification, vet, race tests, and a binary build. Install Go with actions/setup-go before running CI scripts on self-hosted runners so the checks do not depend on runner-local toolchain state. Closes #77.
59ce4c2 to
c52cbb9
Compare
pheidon
requested changes
Jun 7, 2026
pheidon
left a comment
Contributor
There was a problem hiding this comment.
Requesting changes: this PR makes scripts/ci/run-fast-checks.sh depend on Go tooling, but the repository does not contain go.mod or Go source files, so the new fast-check path will fail immediately on , , , and . Please either add the Go module and sources that these commands target, or keep the fast-check script aligned with the repo's actual shell-based layout.
pheidon
approved these changes
Jun 7, 2026
pheidon
left a comment
Contributor
There was a problem hiding this comment.
Approved. The fast-check path now matches the repository layout: go.mod and cmd/machete exist, and the workflows install Go before invoking the new Go-based checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Governing Issue
Closes #77
Validation
bash scripts/ci/run-fast-checks.shGOMODCACHE=/private/tmp/machete-gomodcache GOCACHE=/private/tmp/machete-gocache bash scripts/ci/run-extended-validation.shCI GateBootstrap Governance
CONTRIBUTING.md,.github/PULL_REQUEST_TEMPLATE.md, anddocs/bootstrap/onboarding.mdwhen applicable: not applicable, CI script implementation only.Merge Automation
gh pr merge --auto --squash, or the reason it is unavailable/unsafe is noted below: auto-merge is unsafe until the PR workflow attaches checks; fallback merge-readiness requires local validation plus a clean live PR state.Notes
scripts/ci/lib/bats.shand rantests/*, but those files were removed during the Go migration.gopreinstalled, so this PR also addsactions/setup-go@v5.