Skip to content

Fix Go-era CI fast checks#78

Merged
jmcte merged 1 commit into
mainfrom
codex/fix-go-era-ci
Jun 7, 2026
Merged

Fix Go-era CI fast checks#78
jmcte merged 1 commit into
mainfrom
codex/fix-go-era-ci

Conversation

@jmcte

@jmcte jmcte commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace stale Bats and deleted shell test references in the fast CI entrypoint.
  • Validate the current Go-based repository with shellcheck, Go module verification, vet, race tests, and a binary build.
  • Install Go in PR and extended validation jobs before running the Go-era script on self-hosted runners.

Governing Issue

Closes #77

Validation

  • Relevant local checks passed: bash scripts/ci/run-fast-checks.sh
  • Relevant local checks passed: GOMODCACHE=/private/tmp/machete-gomodcache GOCACHE=/private/tmp/machete-gocache bash scripts/ci/run-extended-validation.sh
  • Required PR checks are expected to satisfy CI Gate
  • Skipped checks are explained below: no checks were skipped locally.

Bootstrap Governance

  • Changes are scoped to the linked issue
  • Contributor or PR guidance changes are reflected in CONTRIBUTING.md, .github/PULL_REQUEST_TEMPLATE.md, and docs/bootstrap/onboarding.md when applicable: not applicable, CI script implementation only.
  • PR author enabled auto-merge where GitHub allows it, or GitHub plan-limit evidence/unavailable reason is recorded and the fallback merge-readiness policy applies: auto-merge is unsafe until GitHub attaches executable PR checks.
  • No real secrets, runtime auth, or machine-local env files are committed

Merge Automation

  • PR author enabled auto-merge with gh pr merge --auto --squash, or the reason it is unavailable/unsafe is noted below: auto-merge is unsafe until the PR workflow attaches checks; fallback merge-readiness requires local validation plus a clean live PR state.

Notes

  • The previous script sourced scripts/ci/lib/bats.sh and ran tests/*, but those files were removed during the Go migration.
  • A manual Extended Validation dispatch on the first revision reached the updated script and showed the self-hosted runner did not have go preinstalled, so this PR also adds actions/setup-go@v5.

@jmcte jmcte requested a review from pheidon as a code owner June 7, 2026 14:04
@jmcte jmcte force-pushed the codex/fix-go-era-ci branch from 1800651 to 59ce4c2 Compare June 7, 2026 14:06
Replace stale Bats and deleted shell test references with the current Go validation surface: shellcheck, module verification, vet, race tests, and a binary build.

Install Go with actions/setup-go before running CI scripts on self-hosted runners so the checks do not depend on runner-local toolchain state.

Closes #77.
@jmcte jmcte force-pushed the codex/fix-go-era-ci branch from 59ce4c2 to c52cbb9 Compare June 7, 2026 14:08

@pheidon pheidon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes: this PR makes scripts/ci/run-fast-checks.sh depend on Go tooling, but the repository does not contain go.mod or Go source files, so the new fast-check path will fail immediately on , , , and . Please either add the Go module and sources that these commands target, or keep the fast-check script aligned with the repo's actual shell-based layout.

@pheidon pheidon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The fast-check path now matches the repository layout: go.mod and cmd/machete exist, and the workflows install Go before invoking the new Go-based checks.

@jmcte jmcte merged commit 1b1218d into main Jun 7, 2026
7 checks passed
@jmcte jmcte deleted the codex/fix-go-era-ci branch June 7, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Go-era CI fast checks

2 participants