fix: import and map Employee Resignation and Resignation Withdrawal i…#156
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds two missing Material Design Icon mappings (file-document-edit-outline and file-undo-outline) to the tree-shaken MdiIcon.vue component so the Employee Resignation and Resignation Withdrawal menu items render their icons correctly.
Changes:
- Import
mdiFileDocumentEditOutlineandmdiFileUndoOutlinefrom@mdi/js. - Register the corresponding kebab-case keys in
iconMap.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ks093
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
Resolves an issue in the mobile app where the menu/dashboard items for Employee Resignation and Resignation Withdrawal rendered as blank/missing symbols.
Problem
The backend DocTypes use the following Material Design Icons:
file-document-edit-outline (for Employee Resignation)
file-undo-outline (for Resignation Withdrawal)
Because the mobile app uses a tree-shakeable SVG icon component (MdiIcon.vue) to avoid loading the entire @mdi/js webfont, icons must be explicitly imported and mapped. Since these two icons were missing from the component's imports and the internal iconMap, they rendered as blank space.
Solution
Imported mdiFileDocumentEditOutline and mdiFileUndoOutline from @mdi/js.
Mapped them to 'file-document-edit-outline' and 'file-undo-outline' in iconMap in
src/components/base/MdiIcon.vue
.
Verification
Verified that the mapping correctly binds the @mdi/js SVG paths.