fix: Penalty Rejection reason mandatory#6203
Open
pjamsheer wants to merge 1 commit into
Open
Conversation
pjamsheer
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the client-side “Reject Penalty” workflow in Penalty to enforce that a rejection reason is provided before the rejection call is made, preventing empty/whitespace submissions.
Changes:
- Marked the rejection reason field as required in the rejection dialog.
- Added client-side validation to block submissions when the reason is empty/whitespace.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
79
to
+83
| primary_action: function(){ | ||
| let {rejection_reason} = rejection_dialog.get_values(); | ||
|
|
||
| // Validate that rejection reason is not empty | ||
| if(!rejection_reason || rejection_reason.trim() === ''){ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the rejection workflow in the
Penaltydoctype by making the "Reason for Rejection" field mandatory and adding validation to ensure a reason is provided before proceeding. This helps enforce required input and prevents accidental submissions without a rejection reason.Enhancements to rejection dialog validation:
rejection_reasonfield required in the rejection dialog for penalties.