chore(WI-000787): Remove Legacy setup.py in wiki#12
Open
Talleyrand333 wants to merge 2 commits into
Open
Conversation
Remove setup.py as pyproject.toml is the modern Python packaging standard. All build configuration is now in pyproject.toml using flit_core. Task: WI-000787
There was a problem hiding this comment.
Pull request overview
Removes the legacy setup.py as part of developer tooling alignment for Frappe v15, which standardizes Python app packaging on pyproject.toml.
Changes:
- Deletes
setup.py(previously the sole source of package name, version, description, author, andinstall_requiresloaded fromrequirements.txt).
Comments suppressed due to low confidence (1)
setup.py:1
- Deleting
setup.pywithout adding corresponding build metadata topyproject.tomlwill break installation of this Frappe app. The currentpyproject.tomlonly contains[tool.black]and[tool.isort]configuration — it does not declare a[build-system]section nor a[project]table (withname,version,dependencies, etc.). As a result,pip install .(which is whatbench get-appruns for Frappe v15 apps) has no way to discover the package name, version, or its runtime dependency onghdifffromrequirements.txt. To align with Frappe v15 tooling, please move the metadata previously insetup.py(name, version sourced fromwiki/__init__.py, description, author, dependencies) into a[project]table inpyproject.tomland declare a[build-system](e.g. setuptools or flit_core).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Talleyrand333
changed the title
yusuffGoodie
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer tooling alignment for Frappe v15.
Task: WI-000787