Skip to content

chore(WI-000789): Add test-on-pr.yml in wiki#14

Merged
yusuffGoodie merged 2 commits into
stagingfrom
WI-000789
May 21, 2026
Merged

chore(WI-000789): Add test-on-pr.yml in wiki#14
yusuffGoodie merged 2 commits into
stagingfrom
WI-000789

Conversation

@Talleyrand333

Copy link
Copy Markdown
Contributor

Developer tooling alignment for Frappe v15.

Task: WI-000789

Copilot AI review requested due to automatic review settings May 14, 2026 14:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a pull request test workflow intended to run Wiki server tests against a Frappe v15 bench environment.

Changes:

  • Introduces a GitHub Actions workflow for PRs targeting staging/test-production/version-15.
  • Provisions MariaDB and Redis services, initializes a Frappe v15 bench, fetches apps, creates a site, and runs Wiki tests.
Comments suppressed due to low confidence (2)

.github/workflows/test-on-pr.yml:45

  • This action is pinned to a mutable version tag rather than an immutable commit SHA. The existing deployment workflows pin actions by SHA, and using tags here allows the executed action code to change without a repository change.
        uses: actions/setup-python@v4

.github/workflows/test-on-pr.yml:50

  • This action is pinned to a mutable version tag rather than an immutable commit SHA. The existing deployment workflows pin actions by SHA, and using tags here allows the executed action code to change without a repository change.
        uses: actions/setup-node@v4

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/test-on-pr.yml
Comment thread .github/workflows/test-on-pr.yml
Comment thread .github/workflows/test-on-pr.yml
Comment thread .github/workflows/test-on-pr.yml
Comment thread .github/workflows/test-on-pr.yml
Comment thread .github/workflows/test-on-pr.yml
Add test execution workflow with:
- Python 3.11, MariaDB 10.6, Redis 6
- bench init with --frappe-branch version-15
- Install app on site before testing
- Coverage reporting to Codecov

Task: WI-000789
@Talleyrand333 Talleyrand333 changed the title chore(WI-000789): developer tooling alignment chore(WI-000789): Add test-on-pr.yml in wiki May 20, 2026
@Talleyrand333 Talleyrand333 removed the request for review from samdanikouser May 20, 2026 16:35
@yusuffGoodie yusuffGoodie merged commit d98a8a1 into staging May 21, 2026
1 of 2 checks passed
@yusuffGoodie yusuffGoodie deleted the WI-000789 branch May 21, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants