Skip to content

feat: Add news notifications#4690

Open
benfurber wants to merge 23 commits intomasterfrom
notifications/add-email-preview
Open

feat: Add news notifications#4690
benfurber wants to merge 23 commits intomasterfrom
notifications/add-email-preview

Conversation

@benfurber
Copy link
Copy Markdown
Member

@benfurber benfurber commented Mar 31, 2026

What kind of change does this PR introduce?

  • 🐛 Bugfix — fixes incorrect behavior without changing functionality
  • ✨ Feature — adds new functionality
  • ♻️ Refactoring — improves code structure with no functional changes
  • ⚡️ Performance — improves speed, memory, or efficiency
  • 🧪 Tests — adds or updates tests only
  • 🔧 Tools / CI — changes to build, deploy, or developer tooling
  • 📝 Documentation — updates docs, comments, or READMEs
  • 📦 Dependencies — upgrades, downgrades, or removes packages
  • 🔖 Other:

What is the new behavior?

  1. Adds in app notification display
571238807-edb0ede2-bdd2-4c10-9a55-346ca97023c3
  1. Adds the ability to set the email visibility of news for badgers
Screenshot 2026-04-16 at 14 29 29
  1. Can change news email notifications
Screenshot 2026-04-16 at 14 53 04
  1. Adds the ability for news content creators to preview how a news article will look like in an email.
Screenshot 2026-03-31 at 15 37 36

Turns out the email components package we're using gives us all of this styling for free:

Screenshot 2026-03-31 at 15 35 31 Screenshot 2026-03-31 at 15 35 40 Screenshot 2026-03-31 at 15 35 43 Screenshot 2026-03-31 at 15 35 48 Screenshot 2026-03-31 at 15 35 53

Does this PR introduce a DB Schema Change or Migration?

  • Yes

Git Issues

Closes #4674

@benfurber benfurber force-pushed the notifications/add-email-preview branch 2 times, most recently from 678aef2 to b15c577 Compare March 31, 2026 12:38
@benfurber benfurber added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Mar 31, 2026
@benfurber benfurber force-pushed the notifications/add-email-preview branch from b15c577 to c1e00d7 Compare March 31, 2026 12:55
@cypress
Copy link
Copy Markdown

cypress bot commented Mar 31, 2026

onearmy-community-platform    Run #9330

Run Properties:  status check failed Failed #9330  •  git commit ad7f7820ff: Merge branch 'master' into notifications/add-email-preview
Project onearmy-community-platform
Branch Review notifications/add-email-preview
Run status status check failed Failed #9330
Run duration 13m 05s
Commit git commit ad7f7820ff: Merge branch 'master' into notifications/add-email-preview
Committer Mário Nunes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 8
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 83
View all changes introduced in this branch ↗︎

Tests for review

Failed  research/write.spec.ts • 2 failed tests • ci-chrome

View Output Video

Test Artifacts
[Research] > [Create research article] > [By Authenticated] Test Replay Screenshots Video
[Research] > [Displays draft updates for Author] > [By Authenticated] Test Replay Screenshots Video
Failed  questions/discussions.spec.ts • 1 failed test • ci-chrome

View Output Video

Test Artifacts
[Questions.Discussions] > allows authenticated users to contribute to discussions Test Replay Screenshots Video
Failed  news/write.spec.ts • 2 failed tests • ci-chrome

View Output Video

Test Artifacts
[News.Write] > Create and update Test Replay Screenshots Video
[News.Write] > Create only for badgers Test Replay Screenshots Video
Failed  library/discussions.spec.ts • 1 failed test • ci-chrome

View Output Video

Test Artifacts
[Library.Discussions] > allows authenticated users to contribute to discussions Test Replay Screenshots Video
Failed  news/discussions.spec.ts • 1 failed test • ci-chrome

View Output Video

Test Artifacts
[News.Discussions] > allows authenticated users to contribute to discussions Test Replay Screenshots Video

The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.

Flakiness  src/integration/research/discussions.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[Research.Discussions] > allows authenticated users to contribute to discussions Test Replay Screenshots Video

@benfurber benfurber force-pushed the notifications/add-email-preview branch from c1e00d7 to ad8f6f6 Compare March 31, 2026 13:31
@benfurber benfurber removed the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Mar 31, 2026
@benfurber benfurber added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Mar 31, 2026
@benfurber benfurber force-pushed the notifications/add-email-preview branch from ad8f6f6 to be650c6 Compare March 31, 2026 13:50
@benfurber benfurber force-pushed the notifications/add-email-preview branch from be650c6 to df92ae3 Compare March 31, 2026 14:34
@benfurber benfurber marked this pull request as ready for review March 31, 2026 14:38
@benfurber benfurber requested a review from a team as a code owner March 31, 2026 14:38
@benfurber benfurber force-pushed the notifications/add-email-preview branch from df92ae3 to f0f5b17 Compare March 31, 2026 16:58
@benfurber benfurber changed the base branch from master to notifications/add-news March 31, 2026 17:02
@benfurber benfurber added Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview and removed Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview labels Mar 31, 2026
@benfurber benfurber force-pushed the notifications/add-email-preview branch from 1af387c to c318898 Compare March 31, 2026 17:29
@benfurber benfurber force-pushed the notifications/add-email-preview branch from c318898 to aa7e9e9 Compare March 31, 2026 17:33
@benfurber benfurber added Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview and removed Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview labels Apr 13, 2026
@benfurber benfurber removed the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[draft] [news] News creators can generate a preview email notification

2 participants