Dac2a bulk support#154
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=======================================
Coverage ? 76.09%
=======================================
Files ? 36
Lines ? 2142
Branches ? 191
=======================================
Hits ? 1630
Misses ? 478
Partials ? 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces version 2.4.0 of the
oda_datapackage, focusing on improved support for DAC2A bulk downloads, schema enhancements, and dependency updates. The most significant changes include the addition of a newDATA_TYPE_CODEfield to the schema and CRS mapping, switching DAC2A bulk downloads to a dedicated function for better reliability, and ensuring that measure filters are skipped for DAC2A bulk downloads (matching CRS behavior). Comprehensive tests have been added to validate these updates.Schema and Mapping Enhancements:
DATA_TYPE_CODEfield to theODASchemaclass and mapped thedatatype_codecolumn inCRS_MAPPINGto this field, supporting new data columns in CRS bulk data files. [1] [2]DATA_TYPE_CODEfield inODASchemaand its mapping inCRS_MAPPING.Bulk Download Improvements:
bulk_download_dac2a()function fromoda-readerfor improved reliability, replacing the previous use ofdownload_dac2a(). [1] [2]bulk_download_dac2a()and cleans data before caching.Filter Logic Updates:
Dependency and Version Updates:
oda-readerdependency from>=1.3.1to>=1.4.1and bumped the package version to 2.4.0. [1] [2]Documentation:
CHANGELOG.mdto reflect all major changes in version 2.4.0.