Skip to content

Dac2a bulk support#154

Merged
jm-rivera merged 1 commit into
mainfrom
dac2a-bulk
Dec 19, 2025
Merged

Dac2a bulk support#154
jm-rivera merged 1 commit into
mainfrom
dac2a-bulk

Conversation

@jm-rivera

Copy link
Copy Markdown
Collaborator

This pull request introduces version 2.4.0 of the oda_data package, focusing on improved support for DAC2A bulk downloads, schema enhancements, and dependency updates. The most significant changes include the addition of a new DATA_TYPE_CODE field to the schema and CRS mapping, switching DAC2A bulk downloads to a dedicated function for better reliability, and ensuring that measure filters are skipped for DAC2A bulk downloads (matching CRS behavior). Comprehensive tests have been added to validate these updates.

Schema and Mapping Enhancements:

  • Added a new DATA_TYPE_CODE field to the ODASchema class and mapped the datatype_code column in CRS_MAPPING to this field, supporting new data columns in CRS bulk data files. [1] [2]
  • Added unit tests to verify the presence of the DATA_TYPE_CODE field in ODASchema and its mapping in CRS_MAPPING.

Bulk Download Improvements:

  • DAC2A bulk downloads now use the dedicated bulk_download_dac2a() function from oda-reader for improved reliability, replacing the previous use of download_dac2a(). [1] [2]
  • Added a unit test to ensure that the DAC2A bulk fetcher uses bulk_download_dac2a() and cleans data before caching.

Filter Logic Updates:

  • Measure filters are now skipped for DAC2A when using bulk downloads, aligning the behavior with CRS bulk downloads.
  • Added a unit test to verify that measure filters are correctly skipped for DAC2A with bulk downloads.

Dependency and Version Updates:

  • Updated the oda-reader dependency from >=1.3.1 to >=1.4.1 and bumped the package version to 2.4.0. [1] [2]

Documentation:

  • Updated the CHANGELOG.md to reflect all major changes in version 2.4.0.

@jm-rivera jm-rivera merged commit bd7ee54 into main Dec 19, 2025
9 checks passed
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@41578d0). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage        ?   76.09%           
=======================================
  Files           ?       36           
  Lines           ?     2142           
  Branches        ?      191           
=======================================
  Hits            ?     1630           
  Misses          ?      478           
  Partials        ?       34           
Flag Coverage Δ
unittests 76.09% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants