Improve caching#157
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage ? 75.64%
=======================================
Files ? 36
Lines ? 2164
Branches ? 198
=======================================
Hits ? 1637
Misses ? 490
Partials ? 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug in the memory cache logic that could return stale or incomplete results when a cached DataFrame did not contain all the columns requested by a subsequent query. The fix ensures that memory cache entries are only used if they include all requested columns, and introduces a projection-specific cache key to store and retrieve column-subset (projected) results separately. This prevents cache pollution and stale data issues for projected reads.
Caching and Query Logic Improvements:
readmethods to only return a cached DataFrame if it contains all requested columns, preventing incomplete results from being served. [1] [2]generate_projection_hashfunction, allowing column-subset (projected) results to be cached and retrieved separately from full-table results. [1] [2]Documentation and Versioning:
2.4.2and updated the changelog to document the cache bug fix. [1] [2]